Skip to content

SF-3973 Allow dismissing user feedback notice - #4247

Open
RaymondLuong3 wants to merge 1 commit into
masterfrom
feature/sf-3973-dismiss-feedback
Open

RaymondLuong3 wants to merge 1 commit into
masterfrom
feature/sf-3973-dismiss-feedback

Conversation

@RaymondLuong3

@RaymondLuong3 RaymondLuong3 commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

This PR adds the option to dismiss the feedback notice. A user who has dismissed the notice will not see the notice again for 180 days. A user who has submitted feedback about draft generation will not see the notice again for 1 year.

This also eliminates the need for the endpoint that gets if a user has submitted feedback because this is now stored on the SFProjectUserConfig of a project per user.

Feedback component dismiss

This change is Reviewable

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label Nov 4, 2026
@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.28%. Comparing base (c429a36) to head (2aca456).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pp/shared/user-feedback/user-feedback.component.ts 66.66% 2 Missing ⚠️
...ate/draft-generation/draft-generation.component.ts 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4247      +/-   ##
==========================================
- Coverage   81.30%   81.28%   -0.02%     
==========================================
  Files         671      671              
  Lines       43020    43011       -9     
  Branches     7138     7139       +1     
==========================================
- Hits        34976    34963      -13     
- Misses       6877     6879       +2     
- Partials     1167     1169       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@RaymondLuong3
RaymondLuong3 force-pushed the feature/sf-3973-dismiss-feedback branch from 0dd9e35 to 2aca456 Compare November 5, 2026 21:54
@RaymondLuong3 RaymondLuong3 added the ai-review-author-sign-off PR author has looked at AI review of change and determined no findings warrant further changes label Nov 5, 2026

@Nateowami Nateowami left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaymondLuong3 What's the plan for the test team to test this? May I propose something like feature/allow-test-feedback-notice-durations?

@Nateowami made 1 comment.
Reviewable status: 0 of 15 files reviewed, all discussions resolved.

This branch was previously deployed

1 inactive deployment
screenshot_diff — 2aca456b Deployed Nov 5, 2026 by RaymondLuong3 via Compare Screenshots #1293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-author-sign-off PR author has looked at AI review of change and determined no findings warrant further changes will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants