Skip to content

Remove the old draft apply dialog translation strings - #4173

Merged
Nateowami merged 1 commit into
masterfrom
fix/remove_old_resources
Oct 6, 2026
Merged

Nateowami merged 1 commit into
masterfrom
fix/remove_old_resources

Conversation

@pmachapman

@pmachapman pmachapman commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

I noticed these resources were unused when working on another PR. Searching the codebase for "draft_apply" only shows up keys in the localization files.


This change is Reviewable

@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.15%. Comparing base (ab06c2a) to head (efddc62).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4173   +/-   ##
=======================================
  Coverage   81.15%   81.15%           
=======================================
  Files         666      666           
  Lines       42620    42620           
  Branches     7070     7043   -27     
=======================================
  Hits        34587    34587           
- Misses       6870     6888   +18     
+ Partials     1163     1145   -18     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Nateowami reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@Nateowami
Nateowami merged commit cdb50ae into master Oct 6, 2026
34 of 35 checks passed
@Nateowami
Nateowami deleted the fix/remove_old_resources branch October 6, 2026 20:46

This branch was successfully deployed

1 active deployment
screenshot_diff — efddc62c Deployed Oct 6, 2026 by pmachapman via Compare Screenshots #1035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants