Add gap between drafted books - #4099
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4099 +/- ##
=======================================
Coverage 80.94% 80.94%
=======================================
Files 664 664
Lines 42153 42153
Branches 6944 6944
=======================================
Hits 34121 34121
Misses 6867 6867
Partials 1165 1165 ☔ View full report in Codecov by Harness. |
Nateowami
force-pushed
the
fix/draft-gap
branch
from
September 11, 2026 01:44
4009cf3 to
441da56
Compare
Nateowami
approved these changes
Sep 11, 2026
Nateowami
left a comment
Nateowami
left a comment
Collaborator
There was a problem hiding this comment.
@Nateowami reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on RaymondLuong3).
src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-preview-books/draft-preview-books.component.scss line 4 at r2 (raw file):
display: flex; gap: 8px; flex-wrap: wrap;
I just added flex-wrap: wrap; because it's also needed and was also dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the gap between books in a draft build. This was a regression from PR #4052
Before
After
This change is