Skip to content

SF-2903 Keep editor scroll position when the footnote dialog closes - #4096

Draft
Nateowami wants to merge 1 commit into
masterfrom
fix/SF-2903-prevent-scroll-on-dialog-close
Draft

SF-2903 Keep editor scroll position when the footnote dialog closes#4096
Nateowami wants to merge 1 commit into
masterfrom
fix/SF-2903-prevent-scroll-on-dialog-close

Conversation

@Nateowami

@Nateowami Nateowami commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

No screenshot differences — all stories are identical.

View the diff page at: https://pr-4096--sf-screenshot-diffs.netlify.app

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.94%. Comparing base (620ea0b) to head (6c0209f).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...re/ClientApp/src/app/shared/text/text.component.ts 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4096   +/-   ##
=======================================
  Coverage   80.94%   80.94%           
=======================================
  Files         664      664           
  Lines       42152    42156    +4     
  Branches     6943     6918   -25     
=======================================
+ Hits        34120    34125    +5     
+ Misses       6882     6881    -1     
  Partials     1150     1150           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Nateowami
Nateowami marked this pull request as ready for review September 10, 2026 14:33
@Nateowami
Nateowami force-pushed the fix/SF-2903-prevent-scroll-on-dialog-close branch from 52f6c9c to 6c0209f Compare September 10, 2026 16:28
@Nateowami
Nateowami marked this pull request as draft September 10, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant