Repository navigation
Pass FwHeadless status through on snapshot regeneration - #2880
Merged
Merged
Conversation
FwHeadlessClient.RegenerateProjectSnapshot now returns (success, statusCode, error) like SyncMercurialAndHarmony, and SyncController uses that status for its Problem response, so an unknown commit or project gives a 404 instead of a 500. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AM78WDo2i51h7253MJHFy9
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
github-actions
Bot
added
the
📦 Lexbox
4 tasks
myieye
pushed a commit
that referenced
this pull request
Oct 31, 2026
Keeps this branch's required commitId with #2880's status-passing return type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AM78WDo2i51h7253MJHFy9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /api/fw-lite/sync/regenerate-snapshot/{projectId}turned every FwHeadless failure into a 500, becauseFwHeadlessClient.RegenerateProjectSnapshotreturned only the response body and the controller calledProblem(result)without a status. FwHeadless answers 404 for an unknown commit id (and for an unknown or never-synced project), so those now come back as a 404 with FwHeadless's message.FwHeadlessClient.RegenerateProjectSnapshotreturns(bool success, HttpStatusCode statusCode, string? error), the same shape asSyncMercurialAndHarmony.SyncController.RegenerateProjectSnapshotpasses that status toProblem(error, statusCode: ...). Other failures keep their own status; transport exceptions still hit the existingcatchand give a 500.FwHeadlessClientTests, a unit test with a mockedHttpMessageHandlerreturning 404.Heads-up: #2877 also edits this method (it makes
commitIdrequired). This PR deliberately leaves the signature's parameters alone, so the merge conflict should be a small one: keep #2877'sGuid commitIdtogether with this PR's tuple return type.Test plan
FwHeadlessClientTests.RegenerateProjectSnapshot_PassesThroughFwHeadlessStatusCodepassescommitIdand get a 404 with "Commit … not found" instead of a 500Generated by Claude Code