Skip to content

Bump Harmony to 0.2.1-rc.445 and export its traces - #2838

Merged
hahn-kev merged 2 commits into
developfrom
chore/bump-harmony
Oct 28, 2026
Merged

hahn-kev merged 2 commits into
developfrom
chore/bump-harmony

Conversation

@hahn-kev-bot

Copy link
Copy Markdown
Collaborator

AI summary

Bumps SIL.Harmony, SIL.Harmony.Core and SIL.Harmony.Linq2db from 0.2.1-rc.397 to 0.2.1-rc.445, and registers Harmony's new SIL.Harmony ActivitySource in LexBoxApi and FwHeadless so its spans are exported.

Harmony changes pulled in:

Test plan

  • LexBoxApi, FwHeadless and FwLiteShared build against rc.445
  • LcmCrdt.Tests sync and snapshot tests pass (DownloadProject, Migration, SnapshotAtCommitService, LegacyTranslationPatchReplay, DataModelSnapshot): 21 passed
  • CI
  • After deploy, SIL.Harmony spans show up in Honeycomb for /api/crdt/*/changes

🤖 Generated with Claude Code

Pulls in sillsdev/harmony#155, which adds a SIL.Harmony ActivitySource
that traces sync planning and recovery. Registers that source in
LexBoxApi and FwHeadless so the spans are exported.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d2ca992f-b8c5-4859-b60d-0befe983f3d2
Commits

Reviewing files that changed from the base of the PR and between 56a6f2b and 238c53d.

Files selected for processing: 4
  • backend/Directory.Packages.props
  • backend/FwHeadless/Program.cs
  • backend/LexBoxApi/Otel/OtelKernel.cs
  • backend/LexBoxApi/openapi/public.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The PR updates the centrally managed SIL.Harmony package versions. It registers Harmony’s activity source in FwHeadless and LexBoxApi. The public ServerCommit schema now requires clientId.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Possibly related PRs

Suggested reviewers: hahn-kev, myieye

Merge Risk: Minimal · up to 238c5

No actionable merge-blocking risk remains from the reviewed changes.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title names the two main parts of the changeset: the Harmony version bump from 0.2.1-rc.397 to rc.445 in the package files, and the registration of Harmony's ActivitySource in LexBoxApi and FwHead…
Description check Passed The description states the purpose of the change: the bump of SIL.Harmony, SIL.Harmony.Core and SIL.Harmony.Linq2db, and the registration of the SIL.Harmony ActivitySource in LexBoxApi and FwHeadless.…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the two main parts of the changeset: the Harmony version bump from 0.2.1-rc.397 to rc.445 in the package files, and the registration of Harmony's ActivitySource in LexBoxApi and FwHeadless so its traces are exported. It is short, specific, and matches the diff summary and PR objectives.

Full details: Description check

Explanation

The description states the purpose of the change: the bump of SIL.Harmony, SIL.Harmony.Core and SIL.Harmony.Linq2db, and the registration of the SIL.Harmony ActivitySource in LexBoxApi and FwHeadless. It also lists the upstream Harmony changes, the test plan, and the unchecked CI and Honeycomb verification items. It is closely related to the changeset.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (2 skipped: 2 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the traces bright,
And sees new Harmony sources in sight.
A commit now carries clientId,
The package versions hop in stride.
Then off I go beneath the moon.

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added 📦 Lexbox issues related to any server side code, fw-headless included 🔩 FW Lite Core Shared MiniLcm, CRDT and sync libraries that ship in both FW Lite and FwHeadless labels Oct 28, 2026
Harmony #152 makes clientId a required member on commits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hahn-kev
hahn-kev merged commit 8fc2028 into develop Oct 28, 2026
29 checks passed
@hahn-kev
hahn-kev deleted the chore/bump-harmony branch October 28, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔩 FW Lite Core Shared MiniLcm, CRDT and sync libraries that ship in both FW Lite and FwHeadless 📦 Lexbox issues related to any server side code, fw-headless included

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants