Skip to content

Explain slow FW Lite project opens with a toast - #2822

Merged
myieye merged 4 commits into
developfrom
ccr-91087c97-9wxbgc
Oct 28, 2026
Merged

myieye merged 4 commits into
developfrom
ccr-91087c97-9wxbgc

Conversation

@myieye

@myieye myieye commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

[Claude, autonomous]

Shows a loading toast while a CRDT project opens, so the full snapshot rebuild from #2813 doesn't look stuck.

  • After 1.5s: "Opening project...". After 8s: "Still opening the project...", with a line explaining that making sure the project is up to date can take a few minutes and asking the user to keep the app open. The skeletons stay as they are.
  • The user can't close the toast. It closes when the open returns or fails, or when the user leaves the project page.
  • The timings are guesses. The 8s text also shows on any slow open, not just after an update.

Screenshots (FwLiteWeb, with an artificial 10s delay before the open). These show an earlier version that included the project name and a "ready" state; the toast's position and style are unchanged:

Loading toast stages

🤖 Generated with Claude Code

https://claude.ai/code/session_01AM78WCP3niyYAq8xbED82r

claude and others added 3 commits October 27, 2026 07:07
The first open after an update can rebuild a project's snapshots, which
takes minutes on large projects while the skeletons look stuck. After 1.5s
a toast the user can't close says the project is opening; after 8s it
explains the wait and asks the user to keep the app open; a slow open ends
with "{name} is ready".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AM78WCP3niyYAq8xbED82r
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8555cffa-9c55-416d-b730-989ea3b2f614
Commits

Reviewing files that changed from the base of the PR and between b636663 and b053bab.

Files selected for processing: 10
  • frontend/viewer/src/DotnetProjectView.svelte
  • frontend/viewer/src/lib/notifications/notifications.ts
  • frontend/viewer/src/locales/en.po
  • frontend/viewer/src/locales/es.po
  • frontend/viewer/src/locales/fr.po
  • frontend/viewer/src/locales/id.po
  • frontend/viewer/src/locales/ko.po
  • frontend/viewer/src/locales/ms.po
  • frontend/viewer/src/locales/sw.po
  • frontend/viewer/src/locales/vi.po

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The viewer now shows timed loading notices while CRDT projects open. The notice can change to a longer-wait message and report success after a slow opening completes. The change also adds notification controls and locale entries; non-English translations are empty.

Priority: Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Possibly related PRs

  • sillsdev/languageforge-lexbox#2813: This PR adds snapshot regeneration on a CRDT model-version upgrade, which can make project opening slow; this change adds notices for slow CRDT project opens.

Suggested reviewers: hahn-kev

Merge Risk: Minimal · up to b053b

No confirmed merge-blocking risk remains in the staged opening notifications.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly summarizes the main change: adding a toast that explains slow FW Lite project opens.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description states that the PR adds a loading toast while a CRDT project opens. It gives the timings (1.5s and 8s), the message text, the close behavior, and a screenshot. This matches the changes…
Full details: Description check

Explanation

The description states that the PR adds a loading toast while a CRDT project opens. It gives the timings (1.5s and 8s), the message text, the close behavior, and a screenshot. This matches the changeset, which adds LoadingNotification in notifications.ts, the opening notice logic in DotnetProjectView.svelte, and the new locale strings. The description is specific and on-topic, so the check passes.

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit watches loading spin,
Then sees the longer message begin.
The project opens; the toast turns bright,
“Ready,” it says, in gentle light.
The rabbit hops into the night.

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Oct 27, 2026

myieye commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator Author

[Claude, autonomous]

frontend is red only because of the Argos screenshot quota: every test passed (10,812 passed, 0 failed), and then the Argos upload was rejected with "You have reached the maximum screenshot capacity included in your Free Plan". That's an account limit, not this PR. I haven't re-run the job, because it will fail the same way until the quota resets or the plan changes.


Generated by Claude Code

@myieye myieye changed the title [claude] Explain slow FW Lite project opens with a toast Explain slow FW Lite project opens with a toast Oct 27, 2026
@myieye
myieye marked this pull request as ready for review October 27, 2026 08:31
@myieye
myieye requested a review from hahn-kev October 27, 2026 08:31
@myieye

myieye commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator Author

@hahn-kev what do you think? I like how generic it is (i.e. no specific events or checks) and how it hopefully makes long waits just chatty enough to assure users that nothing is wrong, there is probably a legitimate reason for the wait and their waiting is not in vain 😅

Start the toast before the name lookup, and just dismiss it when the open
returns: "ready" could show while the page is still loading its own data.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@myieye
myieye merged commit f87d63e into develop Oct 28, 2026
25 checks passed
@myieye
myieye deleted the ccr-91087c97-9wxbgc branch October 28, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants