[hahn-kev-bot]

---

AI summary

Summary

Turn on the Argos reporter's built-in ignoreUploadFailures option in both FW Lite Playwright configs. Argos still logs the error, then prints "Upload failure ignored" instead of failing the run.

 ArgosReporter.onEnd
   upload()
   catch
     log "❌ Error while creating the Argos build"
-    return { status: "failed" }        // job goes red
+    warn "Upload failure ignored"      // job reflects test results

• frontend/viewer/tests/ui/playwright.config.ts
• frontend/viewer/tests/e2e/playwright.config.ts

Evidence

• Before: a run with 145 passed and 5 skipped still failed: APIError: You have reached the maximum screenshot capacity... → ELIFECYCLE exit code 1
• After: not yet seen in CI. The option is in @argos-ci/playwright 6.4.2 (reporter.d.ts), and onEnd only returns failed when it is unset.

Merge Danger

Door: two-way

Revert the two lines to restore failing on upload errors.

Blast Radius: CI-only

Argos upload problems (quota, auth, network) now only show in the job log, not as a red check, so a broken Argos integration could go unnoticed for a while.

Test plan

• FieldWorks Lite frontend job is green when tests pass, even if Argos rejects the upload
• The log still shows the Argos error and the "Upload failure ignored" warning

Closes #2819

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 364412cf-643a-4f8a-8883-667a797fd9c9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: daf47535-b8be-4e7e-8463-6fd3c45c0932

Commits

Reviewing files that changed from the base of the PR and between b636663 and 2eaf80b.

Files selected for processing: 2

• frontend/viewer/tests/e2e/playwright.config.ts
• frontend/viewer/tests/ui/playwright.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Both Playwright configurations now set ignoreUploadFailures: true for the Argos reporter. Their comments state that rejected uploads produce warnings. The UI configuration still enables Argos uploads only when CI is set.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix · Severity of issue fixed: Medium

Possibly related issues

• FW Lite UI tests fail CI when Argos screenshot quota is exhausted — The change configures both affected reporters to ignore rejected uploads.

Possibly related PRs

• sillsdev/languageforge-lexbox#2784 — Adds CI jobs for viewer Chromium UI tests and E2E tests that use these Playwright configurations.

Suggested labels: 💻 FW Lite

Suggested reviewers: hahn-kev

Merge Risk: Minimal · previous review 2eaf8

Argos upload rejection should no longer fail otherwise successful UI test runs.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: preventing FW Lite UI tests from failing when Argos rejects an upload.
Description check		The description directly explains the Argos configuration change, its intended behavior, affected files, evidence, risks, and test plan.
Linked Issues check		Issue #2819 requires Argos upload rejection to stop failing the FieldWorks Lite Playwright job while keeping the failure visible. The PR sets ignoreUploadFailures: true in both `frontend/viewer/test…
Out of Scope Changes check		The PR changes only the two Playwright Argos reporter configurations named by issue #2819. The changes support the issue objective and do not add unrelated behavior.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…

Full details: Linked Issues check

Explanation

Issue #2819 requires Argos upload rejection to stop failing the FieldWorks Lite Playwright job while keeping the failure visible. The PR sets ignoreUploadFailures: true in both frontend/viewer/tests/ui/playwright.config.ts and frontend/viewer/tests/e2e/playwright.config.ts. The changed reporter configuration matches the requested behavior for both Argos integrations.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checked the tests at dawn,
While screenshots hopped away.
“A warning marks the upload miss;
The test results still stay.”
It nibbled clover, pleased to see
The green checks greet the day.}

_{Comment @coderabbitai help to get the list of available commands.}