Repository navigation
Drop .hg/hgrc from uploaded project zips - #2756
Merged
Merged
Conversation
An uploaded zip keeps its whole .hg folder, so its hgrc became the server repo's config, owned by the server user and therefore trusted by Mercurial: hooks and extensions in it would run whenever hgweb, the command runner or a maintenance script touches the repo. Nothing on the server needs a repo-level hgrc (Lexbox-created repos don't have one, hgweb is configured globally, and hgrc never travels with clone/push/pull), so drop it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
the
📦 Lexbox
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Same behaviour, but the file is found by walking the upload instead of by a path built from the project code, which CodeQL flagged as path injection. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hahn-kev
approved these changes
Oct 15, 2026
myieye
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Claude, autonomous]
An uploaded zip's
.hg/hgrcbecame trusted server config, so its hooks and extensions would run whenever hg touched the repo. Nothing server-side needs a repo-level hgrc: Lexbox-created repos have none, hgweb is configured globally, hgresumable never reads one, and hgrc doesn't travel with clone/push/pull. So the reset upload now drops it. Upload is admin-only, so this is defense in depth.🤖 Generated with Claude Code