Skip to content

[claude] Lexicon selector: restored tab with no project shows an unfiltered list after resolveProject #2646

Description

@myieye

[Claude, autonomous]

In the Platform.Bible lexicon extension's Select Lexicon web view, a tab restored from a saved layout can open with no (or a stale) projectId. The first action calls lexicon.resolveProject, which prompts for a project and stores it in resolvedProjectId. But fetchLexicons (platform.bible-extension/src/web-views/select-lexicon.web-view.tsx) closes over the original projectId prop, so after resolution the local list is never refetched for the resolved project — it stays unfiltered by the project's language, and the resolved project's current lexicon isn't pre-selected/badged.

The save is correct (it targets the resolved project); this is display staleness only, in the restored-tab edge case.

Fix sketch: track an effective project id (from prop or resolution), use it in fetchLexicons, refetch on resolution, and load the resolved project's current lexicon code.

Found by a Devin review on #2585; deferred from that PR to keep it scoped to selecting a remote project (non-severe edge case).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions