fix: Use a per-call buffer in RuleBasedCollator.GetSortKey - #240
Open
imnasnainaec wants to merge 1 commit into
Open
imnasnainaec wants to merge 1 commit into
imnasnainaec wants to merge 1 commit into
Conversation
GetSortKey wrote the native sort key into a shared mutable instance field, so concurrent calls on one collator interleaved into the same array and silently returned keys assembled from other threads' strings. The buffer is now local to the call. Growth also allocates exactly the size ucol_getSortKey reports instead of doubling until it fits. Fixes #238 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
imnasnainaec
marked this pull request as ready for review
September 21, 2026 15:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #238.
GetSortKeywrote the native sort key into a shared instance field, so concurrent calls on one collator silently returned keys built from other threads' strings. Each call now uses its own buffer.🤖 Generated with Claude Code
Devin review: https://app.devin.ai/review/sillsdev/icu-dotnet/pull/240