Retire the TeamCity-oriented build path - #236
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
tombogle
added a commit
that referenced
this pull request
Sep 21, 2026
…de bit Devin's review of #236 found three real issues: - Both scripts ran `dotnet test` without specifying a target framework, which attempts net462 (.NET Framework) too. That only works on Windows; CI already gates its net462 test step to windows-latest, so mirror that here by testing net8.0/net10.0 unconditionally and net462 only when $OS is Windows_NT. - Neither script had `set -e`, so a failing `dotnet test` wouldn't stop the script - `dotnet pack` would still run afterward and could succeed, silently masking the test failure. - TestPack.sh was committed with mode 100644 (non-executable). This repo has core.fileMode=false, so a local `chmod +x` before `git add` is never picked up by git; fixed by forcing the bit with `git update-index --chmod=+x`. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
tombogle
force-pushed
the
remove-cruft
branch
from
September 21, 2026 21:40
568500c to
58aad2f
Compare
It built SOLID and was never meant to be in this repo
TeamCity was decommissioned for this project a while ago, and CI now runs entirely through .github/workflows/CI-CD.yml, calling dotnet build/test/pack directly - it never touched icu-dotnet.proj. That file only survived as a manual local-build helper (via TestBuild.sh), still carrying TeamCity detection, a NUnitTeamCity task loaded from TeamCity's agent plugins, and a SIL.BuildTasks-based console-runner test target. Delete icu-dotnet.proj and its NuGet.targets bootstrap, and replace TestBuild.sh with a thin wrapper around the same dotnet CLI commands CI uses so local and CI builds can't drift apart again. Add TestPack.sh alongside it for the pack step. NUnit.Console is no longer needed in icu.net.tests.csproj since it only existed to give icu-dotnet.proj's console-runner target something to run - dotnet test uses NUnit3TestAdapter instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…de bit Devin's review of #236 found three real issues: - Both scripts ran `dotnet test` without specifying a target framework, which attempts net462 (.NET Framework) too. That only works on Windows; CI already gates its net462 test step to windows-latest, so mirror that here by testing net8.0/net10.0 unconditionally and net462 only when $OS is Windows_NT. - Neither script had `set -e`, so a failing `dotnet test` wouldn't stop the script - `dotnet pack` would still run afterward and could succeed, silently masking the test failure. - TestPack.sh was committed with mode 100644 (non-executable). This repo has core.fileMode=false, so a local `chmod +x` before `git add` is never picked up by git; fixed by forcing the bit with `git update-index --chmod=+x`. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
tombogle
force-pushed
the
remove-cruft
branch
from
September 22, 2026 12:32
58aad2f to
d9a79d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #235. TeamCity was decommissioned for this project a while ago, and CI now runs entirely through
.github/workflows/CI-CD.yml, callingdotnet build/test/packdirectly — it never touchedbuild/icu-dotnet.proj.build/icu-dotnet.projand itsbuild/NuGet.targetsbootstrap (TeamCity detection,NUnitTeamCitytask loaded from TeamCity's agent plugins,SIL.BuildTasks-based console-runner test target, legacynuget.exerestore against dead feed URLs).build/TestInstallerBuild.bat, unrelated leftover cruft for building a different repository entirely.build/TestBuild.shas a thin wrapper arounddotnet build/dotnet test, mirroring the CI steps exactly, and addsbuild/TestPack.shalongside it for the pack step — so local and CI builds can't drift apart again.NUnit.Consolefromicu.net.tests.csproj: it only existed to giveicu-dotnet.proj's console-runner target something to run;dotnet testusesNUnit3TestAdapterinstead.Test plan
dotnet build/dotnet test/dotnet packall succeedbuild/TestBuild.shandbuild/TestPack.shlocally end-to-endgit grep -i teamcity/icu-dotnet.proj/NuGet.targets/SIL.BuildTasksreturn no remaining references outside historical CHANGELOG entries🤖 Generated with Claude Code