Skip to content

Respect AlwaysValidateCommits everywhere #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
myieye wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

Respect AlwaysValidateCommits everywhere #127

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40ee699
Respect AlwaysValidateCommits everywhere and default it to off
claude Sep 25, 2026
f0cb074
Keep AlwaysValidateCommits on by default
claude Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/SIL.Harmony/DataModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public async Task AddManyChanges(Guid clientId,
await using var transaction = await repo.BeginTransactionAsync();
var updatedCommits = await repo.AddCommits(commits);
await UpdateSnapshots(repo, updatedCommits);
await ValidateCommits(repo);
if (AlwaysValidate) await ValidateCommits(repo);
await transaction.CommitAsync();
}

Expand Down Expand Up @@ -151,7 +151,7 @@ async Task ISyncable.AddRangeFromSync(IEnumerable<Commit> commits)
await using var transaction = await repo.BeginTransactionAsync();
var updatedCommits = await repo.AddCommits(newCommits);
await UpdateSnapshots(repo, updatedCommits);
await ValidateCommits(repo);
if (AlwaysValidate) await ValidateCommits(repo);
await transaction.CommitAsync();
}
catch (DbUpdateException e)
Expand Down
Loading