fix: stop writing wordSpacing on rich-caption clips#139
Merged
Conversation
|
🎉 This PR is included in version 2.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
RichCaptionStyledeliberately excludeswordSpacing(captions are laid out word-by-word for timed highlighting), but the caption toolbar rendered a word-spacing slider and — worse — the shared spacing controls wrotestyle.wordSpacingunconditionally on every spacing interaction. Any letter-spacing or line-height change on a caption clip therefore produced a style the schema rejects: every subsequent clip commit threwZodError: Unrecognized key "wordSpacing", and the invalid style could be persisted, leaving templates that fail strict validation on reopen.supportsWordSpacing()toolbar hook and omit the key for rich-caption clips; rich-text behaviour is unchanged.How to verify
New tests in
tests/rich-caption-toolbar.test.ts: the caption toolbar renders no word-spacing slider, caption spacing updates omitwordSpacing(both fail on the previous code), and a contrast test pins that rich-text spacing updates still include it. Full suite passes (1864), typecheck and lint clean.