Render pending placeholders for prompt-only media assets#126
Merged
Conversation
…generation fills src
…g in pending video preview
dazzatronus
force-pushed
the
derk/eng-671-prompt-only-pending-players
branch
from
June 12, 2026 06:48
0867768 to
d1c02a7
Compare
…nly-pending-players # Conflicts: # package.json # src/components/canvas/players/audio-player.ts # src/components/canvas/players/image-player.ts # src/components/canvas/players/video-player.ts
|
🎉 This PR is included in version 2.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schemas 1.13 lets media assets (
image/video/audio) carry apromptinstead ofa
src, with generation fillingsrcin place. Studio rendered these as nothing.prompt label, AI icon + label on the timeline. Per-asset, so plain
srcmedia isunaffected. A pending video with a
seedpreviews the seed image.src, the reconciler recreates the clip as a normal mediaplayer. Realised assets keep their AI timeline label.
ClipUnresolvedfires for any pending asset and now also emitsassetType"image" | "video" | "audio"— host apps switching on that field take note.No new rendering code: two pure guards rekey the legacy placeholder system, the
factory routes on pending state, the reconciler recreates on pending flips.
Verify:
npm run devloads a template with every state. 14 new unit tests; suite,typecheck, lint green.
Includes the schemas 1.13 bump and no-src load guards from #123 (superseded). Bundles
@shotstack/schemas1.13.1 (supersedes the dependabot bump) and@shotstack/shotstack-canvas2.10.2.Follow-ups: prompt-editing toolbar, Generate action, export gating for unrealised assets.