Use verification exceptions for Zibal failures - #366
Merged
khanzadimahdi merged 2 commits intoSep 19, 2026
Merged
khanzadimahdi merged 2 commits into
khanzadimahdi merged 2 commits into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #366 +/- ##
=========================================
Coverage ? 80.71%
Complexity ? 1104
=========================================
Files ? 66
Lines ? 5662
Branches ? 0
=========================================
Hits ? 4570
Misses ? 1092
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Throw
InvalidPaymentExceptionwhen Zibal verification receives a non-200 HTTP response or an unsuccessful gateway result. Preserve the existing error codes and translated messages.Motivation and context
These paths currently throw
PurchaseFailedException, so theInvalidPaymentExceptionhandler shown in the README cannot catch them. The change alignsverify()with its documented exception contract. Callers explicitly catching the old purchase exception for these verification failures will need to update their handler.How has this been tested?
Updated the unsuccessful gateway-result regression and added an HTTP 503 regression, checking exception type, message and code. Both fail before the fix. Purchase failures and previously verified transactions retain their existing coverage.
composer cipasses on PHP 8.4.1: PHP_CodeSniffer, PHPStan and the full suite (603 tests, 2240 assertions). No live gateway requests were made.Types of changes
Checklist