Skip to content

fix: fish completion breaks under subshell evaluation #4025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kokhlo wants to merge 3 commits into
base: master
Choose a base branch
from
+7 −1
Open

fix: fish completion breaks under subshell evaluation #4025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fb4a66
Make $bat a global in the fish completions
kokhlo Sep 29, 2026
3244198
Add changelog entry for the fish completion fix
kokhlo Sep 29, 2026
2aebfe3
Merge commit '4608fc959aa8abf80d32198836511a570b7ae9ea' into fix/fish…
kokhlo Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
- Syntax highlighting for Python files using uv as script runner in shebang #3689 (@janlarres)

## Bugfixes
- Fix fish completions failing with `The expanded command was empty` when the completion file is first sourced inside a function, e.g. under a `<TAB>` binding that calls `commandline --function complete`, see #4025 (@kokhlo)
- Track strikethrough (SGR 9 / 29) in the ANSI style tracker so it is re-emitted like bold, dim, italic, and underline, and is no longer dropped after the first highlighted token when displaying ANSI input with syntax highlighting, see #4015 (@mikehasa)
- Allow boolean flags to be given more than once, so that a flag set in the config file can also be passed on the command line without erroring, see #3912 (@logarithmone1128)
- Use parsed CLI arguments to detect number flags, see #3908 (@cuishuang)
Expand Down
7 changes: 6 additions & 1 deletion assets/completions/bat.fish.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@
# ($XDG_CONFIG_HOME is usually set to ~/.config)

# `bat` is `batcat` on Debian and Ubuntu
set bat {{PROJECT_EXECUTABLE}}
# This has to be a global: fish sources completion files in the scope of the
# caller, so an unscoped `set` here would be local to whatever function
# happened to trigger the first completion (e.g. a custom <TAB> binding that
# calls `commandline --function complete`). The helpers below run later, in a
# different scope, and would then see an empty `$bat`.
set -g bat {{PROJECT_EXECUTABLE}}

# Helper functions:

Expand Down
Loading