fix(context-compact): fix L1 truncation bug on consecutive tool results#465
Open
lelewang520 wants to merge 1 commit into
Open
fix(context-compact): fix L1 truncation bug on consecutive tool results#465lelewang520 wants to merge 1 commit into
lelewang520 wants to merge 1 commit into
Conversation
### Summary
Fixes a hidden context truncation bug in the L1 `snip_compact` pipeline where consecutive `tool_result` messages (often generated by parallel tool execution) would cause a validation failure, leading to broken tool/result pairings and API crashes.
### The Problem
In the original `snip_compact` implementation, the tail boundary alignment (`tail_start`) was guarded by a single `if` statement:
```python
if (tail_start > 0 and tail_start < len(messages)
and _is_tool_result_message(messages[tail_start])
and _message_has_tool_use(messages[tail_start - 1])):
tail_start -= 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a hidden context truncation bug in the L1
snip_compactpipeline where consecutivetool_resultmessages (often generated by parallel tool execution) would cause a validation failure, leading to broken tool/result pairings and API crashes.The Problem
In the original
snip_compactimplementation, the tail boundary alignment (tail_start) was guarded by a singleifstatement: