Skip to content

fix: remove obsolete active developer flag - #481

Closed
gitnickolson wants to merge 1 commit into
shardlab:mainfrom
gitnickolson:remove-obsolete-active-developer-flag
Closed

gitnickolson wants to merge 1 commit into
shardlab:mainfrom
gitnickolson:remove-obsolete-active-developer-flag

Conversation

@gitnickolson

@gitnickolson gitnickolson commented Sep 22, 2026 •

Copy link
Copy Markdown

Summary

This PR removes the active developer flag since the badge does not exist anymore, and the flag is not used anywhere (as far as I could see).

Removed

  • :active_developer flag in Discordrb::Data::User

@gitnickolson
gitnickolson force-pushed the remove-obsolete-active-developer-flag branch from 88e5ef1 to bf07618 Compare September 22, 2026 12:09
@gitnickolson gitnickolson changed the title Remove obsolete active developer flag fix: remove obsolete active developer flag Sep 22, 2026
@Droid00000

Copy link
Copy Markdown
Collaborator

This would be a breaking change.

@gitnickolson

Copy link
Copy Markdown
Author

What would be broken?
@Droid00000

@Droid00000

Droid00000 commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

The flags are used to auto-generate predicate methods such as User#staff?, User#hypesquad?, etc. Removing the mapping for the active developer flag would in turn remove the User#active_developer? flag method start raising NoMethodError.

@gitnickolson

Copy link
Copy Markdown
Author

I see, meta programming at it's finest!

I may remove the corresponding method calls as well if you don't have any objections.

@gitnickolson

Copy link
Copy Markdown
Author

Closing this since we're trying to prevent breaking changes as much as we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants