Skip to content

[UIK-5564][Button] Update button styles + removed hardcoded values + some theme initial fixes#3057

Open
j-mnizhek wants to merge 8 commits into
UIK-5351/add-more-variables-to-themefrom
UIK-5564/rebrand-button-styles
Open

[UIK-5564][Button] Update button styles + removed hardcoded values + some theme initial fixes#3057
j-mnizhek wants to merge 8 commits into
UIK-5351/add-more-variables-to-themefrom
UIK-5564/rebrand-button-styles

Conversation

@j-mnizhek

@j-mnizhek j-mnizhek commented Jul 14, 2026

Copy link
Copy Markdown
Member

Changelog

@semcore/button

Changed

  • Styles

Break

  • Remove legacy secondary info theme.

@semcore/theme

Changed

  • Values for color variables
  • Default height for controls: for M — from 28 to 32. for L — from 40 to 44

@semcore/link

Changed

  • Styles

@semcore/modal

Fixed

  • Hardcoded margins in Close button.

@semcore/fullscreen-modal

Fixed

  • Hardcoded margins in Close button.

Motivation and Context

Along with button styles and values for its variables, I had to:

  • update comments in some components according to the new variables names we were discussing with girls
  • remove hardcoded margins in Close button component inside the Modal and FullscreModal
  • remove hardcoded values for w and h in: BaseTrigger, ColorPicker, InputTags, Input, Notice.Label, Pills, TabLine, TimePicker
  • updated variables' values and styles of the Link

How has this been tested?

Manually.

Screenshots (if appropriate):

Current:
image

Updated:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

@j-mnizhek j-mnizhek requested a review from sheila-semrush July 14, 2026 17:01
@j-mnizhek j-mnizhek changed the title [UIK-5564][Button] Upxdate button styles + removed hardcoded values + some theme initial fixes [UIK-5564][Button] Update button styles + removed hardcoded values + some theme initial fixes Jul 14, 2026
@ilyabrower ilyabrower changed the base branch from release/v18 to UIK-5351/add-more-variables-to-theme July 15, 2026 07:15
@j-mnizhek j-mnizhek changed the base branch from UIK-5351/add-more-variables-to-theme to release/v18 July 15, 2026 10:48
@j-mnizhek j-mnizhek changed the base branch from release/v18 to UIK-5351/add-more-variables-to-theme July 15, 2026 11:18
@j-mnizhek j-mnizhek marked this pull request as ready for review July 15, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment