Skip to content

Update discord.mdx - #611

Closed
NFTDreww wants to merge 2 commits into
security-alliance:developfrom
NFTDreww:patch-8
Closed

Update discord.mdx#611
NFTDreww wants to merge 2 commits into
security-alliance:developfrom
NFTDreww:patch-8

Conversation

@NFTDreww

Copy link
Copy Markdown
Collaborator

Added new flows and updates since Discord changed the flow of settings on 8/21/26

What does this PR change?

Type of change

  • New content
  • Edit to existing content
  • Outline / structure change
  • Typo or formatting fix
  • Tooling / config

If applicable

  • Editing existing content: tagged the current contributors from the attribution list
  • Framework has a steward: asked them to review
  • Outline change: updated vocs.config.ts with the dev: true parameter
  • Want community feedback: shared this PR in our Discord

Stuck on anything? Just write it here and we're happy to help.

Added new flows and updates since Discord changed the flow of settings on 8/21/26
@NFTDreww

Copy link
Copy Markdown
Collaborator Author

These changes are reflecting Discord made updates to their platform and changed the setting flow.

However, I just noticed it seems the previous push hasn't gone through on the last update, therefore this does not reflect that...

@github-actions

github-actions Bot commented Aug 22, 2026

Copy link
Copy Markdown
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
frameworks ✅ Ready (View Log) Visit Preview ec5051f

@scode2277 scode2277 added the content:update This issue or PR updates content or suggests to label Aug 27, 2026

@frameworks-volunteer frameworks-volunteer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model: x-ai/grok-4.5 Reasoning: high Provider: openrouter

Security

No issues. Docs-only MDX path/checklist updates; no secrets, scripts, or unsafe content.

QA

Useful refresh of Discord settings paths after the 8/21 UI change, plus two solid Safety Setup items (Restrict prune members to admin, Remove risky permissions for @everyone). CI green.

Blocking

  1. Typo regression in docs/pages/guides/account-management/discord.mdx (Verification Level line):

    • Current: (regist ered on Discord for 5+ minutes)
    • Should be: (registered on Discord for 5+ minutes)
    • Base had this correct; the space was introduced in this PR.
  2. Author note on incomplete push — your comment says a prior push did not land and this branch may not fully reflect the intended update. Please push the remaining changes (or confirm this diff is complete) before merge.

Non-blocking

  • PR template type/checkboxes still empty — fill when convenient.
  • Under Safety Setup > Moderation > Permissions, the note only mentions 2FA; consider broadening it now that prune/@everyone items were added.
  • Please double-check the intended value for Filter messages from server members I may not know > Disabled — for a security checklist, filtering unknown members is often Enabled. Confirm against current Discord UI wording.

Verdict: Request changes for the typo + incomplete-push confirmation. Happy to re-review after the fix.

@scode2277 scode2277 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frameworks-volunteer

Copy link
Copy Markdown
Collaborator

Model: x-ai/grok-4.5 Reasoning: high Provider: openrouter

Re-checked after the follow-up commit.

Status

  • Prior blocking item (typo regist eredregistered) is fixed in ec5051f (scode2277). Confirmed in current head.
  • Security: still clean — docs-only MDX path/checklist updates; no secrets, scripts, or unsafe content.
  • CI: Build Preview, lint, sidebar-reminder, Socket — all pass.

Remaining (non-blocking)

  • Author earlier noted a prior push may not have fully landed. If more Discord UI path updates are still pending, push them; otherwise this diff looks complete for the 8/21 settings rename.
  • Safety Setup > Moderation note still only mentions 2FA; optional broaden now that prune/@everyone items exist.
  • Confirm intended value for Filter messages from server members I may not know > Disabled — security checklists often prefer filtering on; match current Discord UI if wording changed.
  • PR template type/checkboxes still empty.

No second formal review from this bot (prior CHANGES_REQUESTED already on the thread). With the typo fixed and scode2277 approval, remaining notes are optional polish — fine to merge from my side once maintainers are happy with the incomplete-push question.

@NFTDreww

Copy link
Copy Markdown
Collaborator Author

Actually ignore this until this get's merged then I'll redo this on top of it

#613

@scode2277

Copy link
Copy Markdown
Collaborator

hey @NFTDreww quick question: as both of the PRs seem to have the same content at guides/account-management-discord, which one do we close and which one do we keep open to review and merge?
The #611 seems to have less conflicting content that the #613, while keeping the same content in the discord page, so I do suggest closing #613 to favor #611.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content:update This issue or PR updates content or suggests to

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants