add distgen support by ndavidova · Pull Request #295 · sclorg/httpd-container

ndavidova · 2026-05-25T11:58:07Z

No description provided.

ndavidova · 2026-05-25T11:58:13Z

[test]

github-actions · 2026-05-25T11:58:35Z

Pull Request validation

Failed

🔴 Approval - missing or changes were requested

Success

🟢 CI - All checks have passed
🟢 Review - Reviewed by a member

Triggered by Workflow Run

github-actions · 2026-05-25T12:07:01Z

Testing Farm results

name	compose	arch	status	started (UTC)	time	logs
Fedora - 2.4	Fedora-latest	x86_64	✅ passed	03.06.2026 06:11:12	6min 8s	test pipeline
Fedora - 2.4-micro	Fedora-latest	x86_64	✅ passed	02.06.2026 09:18:09	6min 40s	test pipeline
CentOS Stream 10 - 2.4	CentOS-Stream-10	x86_64	✅ passed	03.06.2026 06:11:13	11min 29s	test pipeline
CentOS Stream 9 - 2.4-micro	CentOS-Stream-9	x86_64	✅ passed	01.06.2026 12:36:22	10min 48s	test pipeline
CentOS Stream 10 - 2.4-micro	CentOS-Stream-10	x86_64	✅ passed	02.06.2026 09:00:34	9min 51s	test pipeline
RHEL8 - 2.4	RHEL-8.10.0-Nightly	x86_64	✅ passed	03.06.2026 06:11:14	14min 17s	test pipeline
RHEL10 - Unsubscribed host - 2.4	RHEL-10.2-Nightly	x86_64	✅ passed	03.06.2026 06:11:11	19min 12s	test pipeline
RHEL10 - 2.4	RHEL-10.2-Nightly	x86_64	✅ passed	03.06.2026 06:11:14	19min 57s	test pipeline
RHEL9 - Unsubscribed host - 2.4	RHEL-9.8.0-Nightly	x86_64	✅ passed	03.06.2026 06:11:11	19min 7s	test pipeline
RHEL9 - 2.4	RHEL-9.8.0-Nightly	x86_64	✅ passed	03.06.2026 06:11:11	21min 49s	test pipeline
Fedora - PyTest - 2.4	Fedora-latest	x86_64	✅ passed	01.06.2026 12:34:16	6min 7s	test pipeline
RHEL10 - Unsubscribed host - PyTest - 2.4	RHEL-10.2-Nightly	x86_64	✅ passed	01.06.2026 12:36:27	39min 26s	test pipeline
RHEL9 - Unsubscribed host - PyTest - 2.4	RHEL-9.8.0-Nightly	x86_64	✅ passed	01.06.2026 12:34:22	41min 17s	test pipeline
CentOS Stream 9 - 2.4	CentOS-Stream-9	x86_64	✅ passed	09.06.2026 13:45:37	9min 36s	test pipeline
CentOS Stream 9 - PyTest - 2.4-micro	CentOS-Stream-9	x86_64	✅ passed	01.06.2026 12:36:23	9min 44s	test pipeline
Fedora - PyTest - 2.4-micro	Fedora-latest	x86_64	✅ passed	01.06.2026 12:42:43	7min 31s	test pipeline
CentOS Stream 9 - PyTest - 2.4	CentOS-Stream-9	x86_64	✅ passed	01.06.2026 12:23:59	9min 18s	test pipeline
RHEL9 - PyTest - OpenShift 4 - 2.4	RHEL-9.8.0-Nightly	x86_64	✅ passed	01.06.2026 12:51:06	34min 15s	test pipeline
RHEL10 - PyTest - OpenShift 4 - 2.4	RHEL-10.2-Nightly	x86_64	✅ passed	01.06.2026 12:48:44	48min 44s	test pipeline
CentOS Stream 10 - PyTest - 2.4-micro	CentOS-Stream-10	x86_64	✅ passed	01.06.2026 12:24:01	10min 30s	test pipeline
RHEL8 - PyTest - OpenShift 4 - 2.4	RHEL-8.10.0-Nightly	x86_64	✅ passed	01.06.2026 12:47:09	1h 16min 8s	test pipeline
RHEL8 - PyTest - 2.4	RHEL-8.10.0-Nightly	x86_64	✅ passed	01.06.2026 12:23:59	57min 34s	test pipeline
CentOS Stream 10 - PyTest - 2.4	CentOS-Stream-10	x86_64	✅ passed	01.06.2026 12:23:59	9min 50s	test pipeline
RHEL10 - PyTest - 2.4	RHEL-10.2-Nightly	x86_64	✅ passed	01.06.2026 12:24:00	1h 3min 4s	test pipeline
RHEL9 - PyTest - 2.4	RHEL-9.8.0-Nightly	x86_64	✅ passed	01.06.2026 12:36:19	47min 3s	test pipeline

ndavidova · 2026-05-25T13:35:21Z

[test-all]

phracek

It looks good. I hit only some issues.

Testing Farm and quay.io have some outtages.

So please wait till they are back and online again.

phracek

Thanks for this task. Great.

phracek · 2026-06-02T08:38:48Z

[test]

phracek · 2026-06-03T06:10:30Z

[test]

phracek

@ndavidova Please add also manifest file for '-micro' image.

coderabbitai · 2026-06-09T13:43:17Z

Warning

Review limit reached

@ndavidova, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 2 minutes and 5 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fb8b5426-731c-489b-b367-948763eb0374

📥 Commits

Reviewing files that changed from the base of the PR and between 5dd8f95 and 1d56ad6.

📒 Files selected for processing (108)

2.4-micro/.build-args-c9s
2.4-micro/.exclude-c8s
2.4-micro/2.4-micro
2.4-micro/Dockerfile.c10s
2.4-micro/Dockerfile.c9s
2.4-micro/Dockerfile.fedora
2.4-micro/core-scripts
2.4-micro/root
2.4-micro/root/usr/share/container-scripts/httpd/common.sh
2.4-micro/s2i
2.4-micro/test
2.4-micro/test/__init__.py
2.4-micro/test/check_imagestreams.py
2.4-micro/test/conftest.py
2.4-micro/test/examples
2.4-micro/test/imagestreams
2.4-micro/test/run
2.4-micro/test/run-openshift-pytest
2.4-micro/test/run-openshift-remote-cluster
2.4-micro/test/run-pytest
2.4-micro/test/sample-test-app
2.4-micro/test/self-signed-ssl
2.4-micro/test/settings.py
2.4-micro/test/test-lib-httpd.sh
2.4-micro/test/test-lib-openshift.sh
2.4-micro/test/test-lib-remote-openshift.sh
2.4-micro/test/test-lib.sh
2.4-micro/test/test_container_httpd.py
2.4-micro/test/test_container_httpd_s2i.py
2.4-micro/test/test_ocp_ex_template.py
2.4-micro/test/test_ocp_imagestream_s2i.py
2.4-micro/test/test_ocp_imagestreams.py
2.4-micro/test/test_ocp_integration.py
2.4-micro/test/test_ocp_shared_helm_imagestreams.py
2.4-micro/test/test_ocp_shared_helm_template.py
2.4/root
2.4/root/usr/bin/run-httpd
2.4/root/usr/libexec/httpd-prepare
2.4/root/usr/share/container-scripts/httpd/passwd.template
2.4/root/usr/share/container-scripts/httpd/post-assemble/20-copy-config.sh
2.4/root/usr/share/container-scripts/httpd/post-assemble/40-ssl-certs.sh
2.4/root/usr/share/container-scripts/httpd/pre-init/10-set-mpm.sh
2.4/root/usr/share/container-scripts/httpd/pre-init/20-copy-config.sh
2.4/root/usr/share/container-scripts/httpd/pre-init/40-ssl-certs.sh
2.4/s2i
2.4/s2i/bin/assemble
2.4/s2i/bin/run
2.4/s2i/bin/usage
2.4/test
2.4/test/__init__.py
2.4/test/check_imagestreams.py
2.4/test/conftest.py
2.4/test/examples
2.4/test/imagestreams
2.4/test/pre-init-test-app/httpd-pre-init/modify_index.sh
2.4/test/pre-init-test-app/index.html
2.4/test/run
2.4/test/run-openshift-pytest
2.4/test/run-openshift-remote-cluster
2.4/test/run-pytest
2.4/test/sample-test-app
2.4/test/self-signed-ssl
2.4/test/settings.py
2.4/test/test-lib-httpd.sh
2.4/test/test-lib-openshift.sh
2.4/test/test-lib-remote-openshift.sh
2.4/test/test-lib.sh
2.4/test/test-openshift.yaml
2.4/test/test_container_httpd.py
2.4/test/test_container_httpd_s2i.py
2.4/test/test_ocp_ex_template.py
2.4/test/test_ocp_imagestream_s2i.py
2.4/test/test_ocp_imagestreams.py
2.4/test/test_ocp_integration.py
2.4/test/test_ocp_shared_helm_imagestreams.py
2.4/test/test_ocp_shared_helm_template.py
2.4/test/utils.sh
Makefile
manifest-micro.yml
manifest.yml
specs/multispec.yml
src/Dockerfile
src/Dockerfile.micro
src/README.md
src/root/README.md
src/root/usr/bin/run-httpd
src/root/usr/libexec/httpd-prepare
src/root/usr/share/container-scripts/httpd/README.md
src/root/usr/share/container-scripts/httpd/common.sh
src/root/usr/share/container-scripts/httpd/passwd.template
src/root/usr/share/container-scripts/httpd/post-assemble/20-copy-config.sh
src/root/usr/share/container-scripts/httpd/post-assemble/40-ssl-certs.sh
src/root/usr/share/container-scripts/httpd/pre-init/10-set-mpm.sh
src/root/usr/share/container-scripts/httpd/pre-init/20-copy-config.sh
src/root/usr/share/container-scripts/httpd/pre-init/40-ssl-certs.sh
src/s2i/bin/assemble
src/s2i/bin/run
src/s2i/bin/usage
test/examples
test/pre-init-test-app/httpd-pre-init/modify_index.sh
test/pre-init-test-app/index.html
test/run-openshift-remote-cluster
test/self-signed-ssl
test/test-lib-httpd.sh
test/test-lib-openshift.sh
test/test-lib-remote-openshift.sh
test/test-openshift.yaml
test/utils.sh

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch ndavidov/distgen

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions Bot added the pr/missing-review label May 25, 2026

ndavidova marked this pull request as ready for review May 28, 2026 15:05

ndavidova requested a review from phracek May 29, 2026 11:28

ndavidova force-pushed the ndavidov/distgen branch from 22e5d69 to b4de737 Compare June 1, 2026 10:48

github-actions Bot added the pr/failing-ci label Jun 1, 2026

phracek added the ready for review label Jun 1, 2026

phracek requested changes Jun 1, 2026

View reviewed changes

Comment thread 2.4/Dockerfile.fedora Outdated

Comment thread .github/workflows/container-tests.yml

Comment thread 2.4/Dockerfile.rhel10 Outdated

Comment thread 2.4/Dockerfile.rhel9 Outdated

ndavidova force-pushed the ndavidov/distgen branch from b4de737 to 364a3ff Compare June 1, 2026 12:22

github-actions Bot added pr/changes-requested and removed pr/failing-ci pr/missing-review labels Jun 1, 2026

phracek approved these changes Jun 2, 2026

View reviewed changes

github-actions Bot added pr/failing-ci and removed pr/changes-requested labels Jun 2, 2026

ndavidova force-pushed the ndavidov/distgen branch 2 times, most recently from 7000fba to 404bf36 Compare June 2, 2026 15:12

github-actions Bot added pr/needs-manual-merge and removed pr/failing-ci labels Jun 2, 2026

ndavidova force-pushed the ndavidov/distgen branch from 404bf36 to ca90220 Compare June 2, 2026 15:15

add distgen support

5570e91

ndavidova force-pushed the ndavidov/distgen branch from ca90220 to 5570e91 Compare June 2, 2026 15:37

phracek requested changes Jun 8, 2026

View reviewed changes

github-actions Bot added the pr/changes-requested label Jun 9, 2026

generated sources for micro

1d56ad6

ndavidova force-pushed the ndavidov/distgen branch from f49b5f5 to 1d56ad6 Compare June 9, 2026 13:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add distgen support#295

add distgen support#295
ndavidova wants to merge 2 commits into
masterfrom
ndavidov/distgen

ndavidova commented May 25, 2026 •

edited by github-actions Bot

Loading

Uh oh!

ndavidova commented May 25, 2026

Uh oh!

github-actions Bot commented May 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 25, 2026 •

edited

Loading

Uh oh!

ndavidova commented May 25, 2026

Uh oh!

phracek left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

phracek left a comment

Uh oh!

phracek commented Jun 2, 2026

Uh oh!

phracek commented Jun 3, 2026

Uh oh!

phracek left a comment •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading

Review limit reached

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ndavidova commented May 25, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ndavidova commented May 25, 2026

Uh oh!

github-actions Bot commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request validation

Failed

Success

Uh oh!

github-actions Bot commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing Farm results

Uh oh!

ndavidova commented May 25, 2026

Uh oh!

phracek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

phracek left a comment

Choose a reason for hiding this comment

Uh oh!

phracek commented Jun 2, 2026

Uh oh!

phracek commented Jun 3, 2026

Uh oh!

phracek left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ndavidova commented May 25, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented May 25, 2026 •

edited

Loading

github-actions Bot commented May 25, 2026 •

edited

Loading

phracek left a comment •

edited

Loading

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading