Repository navigation
Conversation
The popup-blocked notice now lives in the tidecloak-js SDK, which shows it when heimdall can't open the enclave popup. Drop KeyleSSH's own banner, its detection helpers and the self-hosted allow-popups.html.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/popups.ts), the blocked-popup icon and the self-hostedallow-popups.html, plus theVITE_POPUP_HELP_URLnote in.env.example.Depends on
Until those are released and
@tidecloak/js/heimdall-tideare bumped here, KeyleSSH shows no pop-up notice at all, so merge this after that bump.Testing