Repository navigation
feat!: move shadow token definitions to repo - #3302
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 4 Skipped Deployments
|
🦋 Changeset detectedLatest commit: f6a113f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
| .sui-shadow4 { box-shadow: var(--shadow-4); } | ||
| .sui-shadow5 { box-shadow: var(--shadow-5); } | ||
| :root { | ||
| --card-shadow-outline-color: light-dark( |
There was a problem hiding this comment.
Would it make sense to remove the card here since we allow shadows on other components as well?
Member
Author
There was a problem hiding this comment.
Oh gosh, I thought I did, apparently my copy paste skills were waning. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to support light-dark versions of our shadow tokens, the tokens are now defined with the UI repo, rather than as DTCG-spec tokens in the tokens studio (as the DTCG spec doesn't have great support for light-dark values, particularly for shadows). The size/length measurements are unchanged, having been inlined from the original token definitions; the colour values now use light-dark and the new shadow colour tokens.
The token values are updated as per the values Lauren logged in the Linear ticket.
What to review
Do the changes look correct?
Testing
Verified appearance in Storybook.
Note
Medium Risk
Touches global shadow styling and theme colours for all elevations; regressions would be visible but limited to presentation, not data or security.
Overview
Shadow tokens now live in the UI package instead of DTCG tokens from Tokens Studio, so each shadow layer can use
light-dark()for outline/umbra/penumbra/ambient colors while keeping the same offsets as before.The new values follow the Linear spec (SDK-2978) so shadows no longer invert incorrectly in dark mode.
@sanity-labs/design-tokensis bumped to0.0.2-alpha.10with lockfile andminimumReleaseAgeExcludealigned; a patch changeset notes the release.Review focus: confirm shadow steps 0–5 and utility classes (
sui-shadow*) still match product intent in Storybook/light-dark.Reviewed by Cursor Bugbot for commit f6a113f. Bugbot is set up for automated code reviews on this repo. Configure here.