the SvtxAlignmentState initializers do not work for debug builds

[pinkenburg]

Types of changes

• [ X] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work for users)
• Requiring change in macros repository (Please provide links to the macros pull request in the last section)
• I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

The debug build choked on the SvtxAlignmentState initializer. This should fix this while still working with optimized code. This PR is courtesy of codex

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

Motivation

Debug builds fail when SvtxAlignmentState uses its static integer constants. This change provides the definitions needed for those uses.

Key changes

• Added out-of-class definitions for NGL, NLOC, and NRES in SvtxAlignmentState.cc.
• Existing accessors remain unchanged.

Potential risk areas

• No IO format, reconstruction behavior, thread-safety, or performance changes are indicated.
• Test results are not available in the supplied information.

Possible future improvements

• Confirm the fix in both debug and optimized builds.

AI-generated summaries can contain errors. This summary is based on the supplied change description; verify it against the source and build results.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: sPHENIX-Collaboration/coresoftware/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 3f768d64-4147-463b-a621-10b89d41d382

📥 Commits

Reviewing files that changed from the base of the PR and between 2a2e56e and be9c383.

📒 Files selected for processing (1)

• offline/packages/trackbase_historic/SvtxAlignmentState.cc

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

SvtxAlignmentState.cc now defines the static integer constants NGL, NLOC, and NRES outside the class. Existing accessors are unchanged.

Changes

Alignment state constants

Layer / File(s)	Summary
Define static integer constants offline/packages/trackbase_historic/SvtxAlignmentState.cc	Adds out-of-class definitions for NGL, NLOC, and NRES.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to be9c3

The definitions address uses of these constants that require storage without changing accessor behavior. No actionable merge risk is evident in the reviewed change.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sphenix-jenkins-ci]

Build & test report

Report for commit be9c383b957c63d55d536da7a4da7fbc20a9776a:

• builds and tests overall are FAILURE.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is FAILURE, 📊Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is FAILURE, 📊 trends
  • Tracking QA with Distortions: build is FAILURE, 📊 trends
  • Tracking QA at low occupancy: build is FAILURE, 📊 trends
  • Tracking QA for Pythia D0-jet: build is FAILURE, 📊 trends
  • Tracking QA runnumber 53877: build is FAILURE, 📊 trends
  • Tracking QA runnumber 79513: build is FAILURE, 📊 trends
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2_Fitting.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is FAILURE, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is FAILURE, 📊valgrind report, trends 📊
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
• clang-tidy is SUCCESS, 📊clang-tidy report (full)/(new)
• cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration
           

[sphenix-jenkins-ci]

Build & test report

Report for commit be9c383b957c63d55d536da7a4da7fbc20a9776a:

• builds and tests overall are FAILURE.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is FAILURE, 📊Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is FAILURE, 📊 trends
  • Tracking QA with Distortions: build is FAILURE, 📊 trends
  • Tracking QA at low occupancy: build is FAILURE, 📊 trends
  • Tracking QA for Pythia D0-jet: build is FAILURE, 📊 trends
  • Tracking QA runnumber 53877: build is FAILURE, 📊 trends
  • Tracking QA runnumber 79513: build is FAILURE, 📊 trends
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2_Fitting.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is FAILURE, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is FAILURE, 📊valgrind report, trends 📊
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
• clang-tidy is SUCCESS, 📊clang-tidy report (full)/(new)
• cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration