Reduce default track pT cut in KshortReconstruction

[adfrawley]

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• [ x] New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work for users)
• Requiring change in macros repository (Please provide links to the macros pull request in the last section)
• I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

Reduce default track pT cut in KshortReconstruction from 200 MeV to 100 Mev, so as not to cut off valid reconstructed polyseed tracks. Has a very large effect on low pT reconstructed Lambda decays.

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

Summary

This change lowers the default KshortReconstruction::track_pt_cut from 200 MeV to 100 MeV. This helps retain valid low-(p_T) polyseed tracks and can increase sensitivity to low-(p_T) reconstructed Lambda decays.

Key changes

• Set track_pt_cut to 0.1.
• Keep the existing setTrackPtCut configuration interface.
• Make no reported public API or I/O format changes.

Potential risk areas

• Reconstruction output can change for low-(p_T) tracks.
• Candidate counts and processing time may increase.
• No thread-safety or I/O format impact is indicated.
• Test results and review severity counts are unavailable.

Possible future improvements

• Add regression tests for low-(p_T) polyseed tracks and Lambda decays.
• Measure reconstruction efficiency, background, and processing time.
• Document the expected operating range for track_pt_cut.

AI-generated summaries can contain mistakes. Contributors should verify this change against implementation details and physics validation results.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: sPHENIX-Collaboration/coresoftware/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 1016faa6-a044-4d3c-a706-e45d2d129e20

📥 Commits

Reviewing files that changed from the base of the PR and between e17a9aa and 31709ca.

📒 Files selected for processing (1)

• offline/packages/TrackingDiagnostics/KshortReconstruction.h

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The default track_pt_cut value in Kshort reconstruction changes from 0.2 to 0.1.

Changes

Tracking diagnostics

Layer / File(s)	Summary
Track pT default offline/packages/TrackingDiagnostics/KshortReconstruction.h	The default track_pt_cut value changes from 0.2 to 0.1.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 31709

No actionable merge-blocking risk was identified.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sphenix-jenkins-ci]

Build & test report

Report for commit 31709cae51ce6edbe15cb576f339926b3d14c4d2:

• builds and tests overall are SUCCESS.
• Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
• Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
  • Generating DST and readback: build is SUCCESS
  • Calorimeter QA: build is SUCCESS, 📊 trends
    • 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 49.8894 / 72, and combined p-Value = 0.978165
    • 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 34.6977 / 72, and combined p-Value = 0.99994
    • 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 89.0492 / 42, and combined p-Value = 3.12982e-05
    • 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 15.0901 / 42, and combined p-Value = 0.999958
  • Tracking QA with Distortions: build is SUCCESS, 📊 trends
    • 📊 QA-distortions
  • Tracking QA at low occupancy: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
  • Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
    • 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
    • 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
    • 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
    • 📊 QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
    • 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
  • Tracking QA runnumber 53877: build is SUCCESS, 📊 trends
    • 📊 QA-intt : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
    • 📊 QA-micromegas : combined Chi2/nDoF = -0 / 6, and combined p-Value = 1
    • 📊 QA-mvtx : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
    • 📊 QA-siliconseeds : combined Chi2/nDoF = 3.3382e-07 / 20, and combined p-Value = 1
    • 📊 QA-tpc : combined Chi2/nDoF = -0 / 48, and combined p-Value = 1
    • 📊 QA-tpcseeds : combined Chi2/nDoF = -0 / 28, and combined p-Value = 1
    • 📊 QA-trackfit : combined Chi2/nDoF = -0 / 32, and combined p-Value = 1
  • Tracking QA runnumber 79513: build is SUCCESS, 📊 trends
    • 📊 QA-intt : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
    • 📊 QA-micromegas : combined Chi2/nDoF = -0 / 6, and combined p-Value = 1
    • 📊 QA-mvtx : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
    • 📊 QA-siliconseeds : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
    • 📊 QA-tpc : combined Chi2/nDoF = -0 / 48, and combined p-Value = 1
    • 📊 QA-tpcseeds : combined Chi2/nDoF = -0 / 28, and combined p-Value = 1
    • 📊 QA-trackfit : combined Chi2/nDoF = -0 / 32, and combined p-Value = 1
  • system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2_Fitting.C: build is SUCCESS, 📊valgrind report, trends 📊
  • system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
  • system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
• Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
• clang-tidy is SUCCESS, 📊clang-tidy report (full)/(new)
• cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

---

Automatically generated by sPHENIX Jenkins continuous integration