Unify admin user search with email lookup - #491
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes Admin dashboard/user lookup by centralizing user searching into a User.search scope that searches by name and associated Email records, and then reusing that scope across admin controllers.
Changes:
- Added a
User.searchscope to support searching users by name or email (via theEmailmodel). - Updated Admin dashboard and Admin user search endpoints to use the shared
User.searchscope. - Added a request spec covering Admin dashboard search by name and by email.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spec/requests/admin/dashboard_spec.rb | Adds request coverage for dashboard user search by name/email. |
| app/models/user.rb | Introduces User.search scope used by admin search flows. |
| app/controllers/admin/users_controller.rb | Reuses User.search for the JSON user search endpoint. |
| app/controllers/admin/memberships_controller.rb | Updates membership filtering to support email lookup via Email user_ids. |
| app/controllers/admin/dashboards_controller.rb | Switches dashboard search filtering to use User.search. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves an issue with looking up users in the Admin dashboard.