Complete hasht tests#988
Closed
matsl wants to merge 1 commit into
Closed
Conversation
matsl
commented
Jun 25, 2026
matsl
commented
Jun 25, 2026
matsl
commented
Jun 25, 2026
rswgnu
requested changes
Jun 25, 2026
rswgnu
left a comment
rswgnu
left a comment
Owner
There was a problem hiding this comment.
I merged this with fixes. Close this PR.
Collaborator
Author
|
Already applied. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Complete hasht tests.
Why
Add some more tests for hasht. Almost full code coverage.
Note
The merge functions have slightly odd behavior with difference in
merging singular values and lists. The tests are coded to succeed so
the should clauses need to be checked if they make sense. I'll add
review comments to point out where I have questions.