Log noise type and value of each of the sensor components - #314
Merged
Merged
Conversation
saikishor
requested review from
eholum-nasa,
ndunkelb-nasa and
scastro-nasa
September 26, 2026 15:58
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
==========================================
- Coverage 82.73% 82.70% -0.03%
==========================================
Files 35 35
Lines 5896 5904 +8
Branches 601 602 +1
==========================================
+ Hits 4878 4883 +5
- Misses 698 701 +3
Partials 320 320
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ndunkelb-nasa
previously approved these changes
Sep 27, 2026
ndunkelb-nasa
left a comment
Collaborator
There was a problem hiding this comment.
Looks pretty straightforward! Just one question about the use of the to_string(), otherwise good to go.
Comment on lines
+90
to
+93
| inline const char* to_string(NoiseDistribution distribution) | ||
| { | ||
| return distribution == NoiseDistribution::kUniform ? "uniform" : "gaussian"; | ||
| } |
Collaborator
There was a problem hiding this comment.
Is this planned to be re-used elsewhere? Seems kind of silly to have a one-liner function to just be used in one place which could just have the original implementation.
Member
Author
There was a problem hiding this comment.
Truee, right now no plans to use in atleast
Member
Author
There was a problem hiding this comment.
I can modify it. Thanks
ndunkelb-nasa
approved these changes
Sep 30, 2026
saikishor
enabled auto-merge (squash)
September 30, 2026 18:59
saikishor
disabled auto-merge
September 30, 2026 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Logs the type of ssensor noise and the noise value of each component. This helps to see if the changes are relfected.
Is this user-facing behavior change?
NO
Did you use Generative AI?
Logic simplification, Claude Sonnet