[ntuple] Enable shared access to RNTupleFileWriter#21593
Open
silverweed wants to merge 2 commits into
Open
Conversation
Test Results 20 files 20 suites 3d 7h 16m 7s ⏱️ For more details on these failures, see this check. Results for commit c7f4119. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
minifile_shared
branch
2 times, most recently
from
4df8bec to
0e31934
Compare
silverweed
changed the title
silverweed
changed the title
silverweed
force-pushed
the
minifile_shared
branch
2 times, most recently
from
613f3e4 to
f2c8fde
Compare
jblomer
approved these changes
Jun 15, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Apologies for the huge reviewing delay!
silverweed
force-pushed
the
minifile_shared
branch
from
f2c8fde to
ccdccdc
Compare
silverweed
force-pushed
the
minifile_shared
branch
from
ccdccdc to
c7f4119
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow for multiple RNTupleFileWriters to share a single underlying Simple file. This is required for attribute writing support in Minifile-backed RNTuples.
The idea is turning all shared properties of RImplSimple into a
shared_ptr-accessed struct which is referenced by all clones of a Writer. Access is strictly single-threaded but that's enough for attribute writing.