[main] optparse: add support for prefix flags (per-flag version)#20947
Merged
Conversation
2 tasks
Contributor
|
Thanks @silverweed. I've updated the draft PR: #20903 to use this. |
Test Results 22 files 22 suites 3d 12h 42m 30s ⏱️ For more details on these failures, see this check. Results for commit c1b0b4f. ♻️ This comment has been updated with latest results. |
devajithvs
approved these changes
Jan 21, 2026
devajithvs
left a comment
devajithvs
left a comment
Contributor
There was a problem hiding this comment.
Thanks. LGTM except the way we handle prefix flags with equals.
silverweed
force-pushed
the
optparse_prefix2
branch
from
85675a8 to
c1b0b4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative version of #20923, that allows to define prefix flags per-flag rather than globally.