feat(tools): binding.invoke tracing for tool-call visibility#121
Open
NathanFlurry wants to merge 1 commit into
Open
feat(tools): binding.invoke tracing for tool-call visibility#121NathanFlurry wants to merge 1 commit into
NathanFlurry wants to merge 1 commit into
Conversation
Add debug/warn/info tracing to resolve_toolkit_command (the binding.invoke resolution + policy gate) so a host-tool call is observable end-to-end: resolving, unknown-callback, blocked-by-policy, and resolved (with timeout_ms). Emitted on the secure_exec_sidecar::tools target; surfaces once the consuming sidecar enables RUST_LOG/EnvFilter (see the agent-os configurable-logging PR). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🚅 Deployed to the secure-exec-pr-121 environment in rivet-frontend
🚅 Deployed to the secure-exec-pr-121 environment in secure-exec
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add tracing to
resolve_toolkit_commandincrates/sidecar/src/tools.rs— thebinding.invokeresolution + policy gate that runs when a guest invokes a registered host tool. Today this path is completely silent, so a host-tool call can't be observed.New events (target
secure_exec_sidecar::tools):debug!— resolving tool callback (callback_key)warn!— unknown tool callbackwarn!— blocked by binding.invoke policyinfo!— resolved tool callback (callback_key,timeout_ms)Why
Debugging a tool-call hang in a consumer (
timed out waiting for sidecar protocol frame for ext, "hangs before the tool fires"), the sidecar emitted nothing on the tool path. These four events make the hop visible: was the tool resolved, was it unknown, or was it blocked by policy — which splits "stuck in resolution/policy" from "stuck in the host round-trip."Notes
RUST_LOG/EnvFilter— pairs with the agent-os PR that makesagentos-sidecarlogging configurable (rivet/agentos#1517).cargo checkpasses.