Skip to content

Internal: Fix caption inspector track selection - #12179

Closed
alec-watts wants to merge 1 commit into
remotion-dev:mainfrom
alec-watts:codex/fix-caption-inspector-e2e
Closed

alec-watts wants to merge 1 commit into
remotion-dev:mainfrom
alec-watts:codex/fix-caption-inspector-e2e

Conversation

@alec-watts

@alec-watts alec-watts commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

The caption persistence E2E test tries to select <AnimatedCaptions>, but the timeline exposes the track as a group named AnimatedCaptions. The click never selects the track, so the test times out before exercising caption edits. This also fails on current main (run 37958943104).

Select the track by its existing accessible group name, matching the pattern already used for the default captions track in this test. Caption editing, import validation, and source-persistence assertions are unchanged.

Validation: both caption-inspector E2E tests pass against the actual Studio in native Chrome. Restoring the old selector reproduces the timeout. All 64 testbed dependency builds pass.

Why each file changes

File Reason
packages/example/e2e/captions-inspector.test.mts Select the actual timeline group so existing caption persistence coverage runs.

Remaining CI failures

The caption-inspector cases pass after this change. Run 37990648027 still fails in two unrelated baseline cases: the one-Lambda render integration test exceeds Bun’s default 5-second timeout, and the effect-keyframes precision test cannot find the Opacity row after selecting Timeline expansion. The keyframe case passes alone and with its sibling test locally, but fails in the complete Studio suite. A trial selecting the timeline bar instead of the first same-named group did not repair it and was discarded. No unverified test changes are included. GitHub requires repository admin rights to rerun failed jobs.

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
bugs Ready Ready Preview Oct 9, 2026 9:11pm UTC
remotion Ready Ready Preview Oct 9, 2026 9:11pm UTC

Request Review

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Caption inspector E2E track selection — packages/example/e2e/captions-inspector.test.mts now locates the inline captions timeline track via getByRole('group', {name: 'AnimatedCaptions', exact: true}) instead of getByText('<AnimatedCaptions>'), aligning it with the pattern already used for the default captions track in the same test. AnimatedCaptions has no name prop, so Interactive.tsx:476 falls back to componentName ('AnimatedCaptions'), which becomes the track's displayName (Sequence.tsx:550) and its accessible aria-label on the role="group" track item (TimelineSequence.tsx:664) — the new locator resolves to the real track, whereas the angle-bracketed text was never rendered.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash | 𝕏

JonnyBurger commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Closing as already applied on main: commit d9d4b74 landed on October 11 with the identical one-line selector fix.

The caption test failure was real on October 9: main run 37958943104 timed out while trying to select the caption track. The test searched for <AnimatedCaptions> instead of the actual accessible group named AnimatedCaptions.

This PR's remaining red checks are from October 9, after the caption tests passed:

A subsequent main run was fully green. Another later run passed both browser and Lambda tests but failed a separate media test concerning audio during reverse playback. Those CI failures can be investigated separately; this selector fix is already present on main, so no additional merge is needed here.

Thank you for tracking this down and putting together the fix! We appreciate the investigation and contribution, even though the same change has since landed on main.

This branch was successfully deployed

2 active deployments
Preview – remotion — 42b4d8aa Deployed Oct 9, 2026 by vercel[bot]
Preview – bugs — 42b4d8aa Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants