Repository navigation
Internal: Fix caption inspector track selection - #12179
alec-watts wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Caption inspector E2E track selection —
packages/example/e2e/captions-inspector.test.mtsnow locates the inline captions timeline track viagetByRole('group', {name: 'AnimatedCaptions', exact: true})instead ofgetByText('<AnimatedCaptions>'), aligning it with the pattern already used for the default captions track in the same test.AnimatedCaptionshas nonameprop, soInteractive.tsx:476falls back tocomponentName('AnimatedCaptions'), which becomes the track'sdisplayName(Sequence.tsx:550) and its accessiblearia-labelon therole="group"track item (TimelineSequence.tsx:664) — the new locator resolves to the real track, whereas the angle-bracketed text was never rendered.
deepseek-v4.1-flash | 𝕏
|
Closing as already applied on The caption test failure was real on October 9: main run 37958943104 timed out while trying to select the caption track. The test searched for This PR's remaining red checks are from October 9, after the caption tests passed:
A subsequent main run was fully green. Another later run passed both browser and Lambda tests but failed a separate media test concerning audio during reverse playback. Those CI failures can be investigated separately; this selector fix is already present on Thank you for tracking this down and putting together the fix! We appreciate the investigation and contribution, even though the same change has since landed on |

The caption persistence E2E test tries to select
<AnimatedCaptions>, but the timeline exposes the track as a group namedAnimatedCaptions. The click never selects the track, so the test times out before exercising caption edits. This also fails on current main (run 37958943104).Select the track by its existing accessible group name, matching the pattern already used for the default captions track in this test. Caption editing, import validation, and source-persistence assertions are unchanged.
Validation: both caption-inspector E2E tests pass against the actual Studio in native Chrome. Restoring the old selector reproduces the timeout. All 64 testbed dependency builds pass.
Why each file changes
packages/example/e2e/captions-inspector.test.mtsRemaining CI failures
The caption-inspector cases pass after this change. Run 37990648027 still fails in two unrelated baseline cases: the one-Lambda render integration test exceeds Bun’s default 5-second timeout, and the effect-keyframes precision test cannot find the Opacity row after selecting Timeline expansion. The keyframe case passes alone and with its sibling test locally, but fails in the complete Studio suite. A trial selecting the timeline bar instead of the first same-named group did not repair it and was discarded. No unverified test changes are included. GitHub requires repository admin rights to rerun failed jobs.