pbyr-4653/chore(jsf) - move local json schema for Termination, ContractorOnboarding and CreateCompany to v1 - #1271
Merged
jordividaller merged 1 commit intoSep 4, 2026
Conversation
… static schemas to v1
Declare `x-rmt-meta: { jsfVersion: '1' }` on the static schemas of these
three flows so they run on json-schema-form v1 instead of the v0 fallback.
The form kit stays pinned at 0.0.23, where a schema without an explicit
`x-rmt-meta` still falls back to v0, so every other flow is unaffected.
Onboarding/selectCountryStep keeps the v0 fallback until the select-country
issue is fixed, which also leaves the ContractorOnboarding select-country
step and PayrollAdminOnboarding on v0.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
All concerned flows has been manually tested to be sure we do not have regression. |
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (421 total)
✅ Bundle size check passed |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
cammellos
approved these changes
Sep 4, 2026
jordividaller
deleted the
chore/jsf-v1-termination-contractor-onboarding-create-company
branch
September 4, 2026 14:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Declare
x-rmt-meta: { jsfVersion: '1' }on the static JSON schemas of three flows,so they render and validate with json-schema-form v1 instead of the v0 fallback:
Termination/json-schemas(6 files, including theallOfconditionals)ContractorOnboarding/json-schemas(5 files)CreateCompany/json-schemas/companyBasicInformationStep.tsThe stamp is placed on the object that is actually handed to
createHeadlessForm,so it survives the derived schemas built at runtime (currency injection in
createInvoiceSchedule, the composedTermination/jsonSchema).Why
Step towards the full v1 migration. The form kit stays pinned at
0.0.23, where aschema without an explicit
x-rmt-metastill falls back to v0 — so every other flowis untouched and this can land on its own, ahead of the kit bump.
Out of scope
Onboarding/json-schemas/selectCountryStepstays on v0 until the select-countryissue is fixed. It is shared, so the ContractorOnboarding select-country step and
PayrollAdminOnboarding stay on v0 too.
Testing
getMetaVersionthat all 12 schemas — plus the derivedcreateInvoiceSchedulevariant — resolve tov1.example/on the three flows: validation errors, conditional fields,coercion of number, money and checkbox values, and error messages.
Note
Medium Risk
Behavior of validation, conditionals, and field coercion can differ between JSF v0 and v1 on employee termination and onboarding forms, even though the diff is metadata-only.
Overview
Adds
x-rmt-meta: { jsfVersion: '1' }to the root schema object passed into the form kit for Termination (step schemas plus the composedjsonSchema), ContractorOnboarding (five step schemas, includingcreateInvoiceScheduleso runtime currency injection keeps v1), and CreateCompany (companyBasicInformationStep).Those flows opt out of the v0 default while the kit stays on
0.0.23; other flows without the stamp are unchanged. This is an incremental step toward a full v1 migration, not a dependency bump.Reviewed by Cursor Bugbot for commit 48669c4. Bugbot is set up for automated code reviews on this repo. Configure here.