Unify unit conversions for tax convergence and rollback - #2423
Draft
simonkrogmann wants to merge 1 commit into
Draft
Unify unit conversions for tax convergence and rollback#2423simonkrogmann wants to merge 1 commit into
simonkrogmann wants to merge 1 commit into
Conversation
simonkrogmann
marked this pull request as draft
August 6, 2026 12:42
simonkrogmann
force-pushed
the
unify-conv
branch
2 times, most recently
from
August 6, 2026 13:19
fffe327 to
b92a9cf
Compare
simonkrogmann
force-pushed
the
unify-conv
branch
from
August 6, 2026 13:39
b92a9cf to
110b40c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This refactors some unit handling in the tax module: Move conversions from preloop to datainput.
Questions:
x * sm_non_2_trillion / sm_GJ_2_TWa? Both are around 1e-12.I also added some files to the gitignore that (temporarily) show up in my personal environment.
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)