[DeadCode] Skip used by ReflectionMethod as array callable on RemoveUnusedPrivateMethodParameterRector#8198
Closed
samsonasik wants to merge 2 commits into
Closed
[DeadCode] Skip used by ReflectionMethod as array callable on RemoveUnusedPrivateMethodParameterRector#8198samsonasik wants to merge 2 commits into
samsonasik wants to merge 2 commits into
Conversation
…nusedPrivateMethodParameterRector
Member
Author
|
@TomasVotruba ready 👍 |
Member
|
Where is this fixture coming from? Not sure if worth checking, as traversing whole class is costly. |
Member
Author
|
The usecase is on spiral framework |
Member
|
I see. Test fixture with these hacks should be skipped, as they violate most of dead-code rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref
https://3v4l.org/nZRSU#v8.1.34 vs https://3v4l.org/2vaUL#v8.1.34