fix(ios): resolve ImportReact.h in Expo modular builds - #639
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe podspec adds the public-header search path and includes ChangesCocoaPods header integration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The narrowly scoped Expo podspec updates introduce no identified merge-blocking behavior or production risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DEFINES_MODULE generates an umbrella that imports public headers, but ImportReact.h was public-only and the hyphenated Headers/Public path was not on the search list, so Expo SDK 57 compiles failed.
7861f35 to
3ac5b48
Compare
Bump package.json and harmony/pushy/oh-package.json5 together for the Expo iOS public-header fix from #639. No additional runtime changes.
Summary
DEFINES_MODULE+ modular-header setups) generatereact-native-update-umbrella.hunderHeaders/Public/react_native_update/(underscores). That umbrella#import "ImportReact.h".ImportReact.hwas markedpublic_header_filesbut notsource_files, so CocoaPods never copied it intoHeaders/Public. Combined with the hyphenated public-header dir (react-native-update/) missing fromUSER_HEADER_SEARCH_PATHS, iOS compile failed with'ImportReact.h' file not found.ios/ImportReact.htosource_filesin the Expo branch, and put$(PODS_ROOT)/Headers/Public/react-native-updateon the search path (PODS_ROOT, not a machine-specific source path).Test plan
use_expo_modules!and modular headers:pod install, then compile the iOS target. The umbrella should findImportReact.h.ios/Pods/Headers/Public/react-native-update/ImportReact.hexists afterpod install.source_filesbranch is gated onuse_expo_modules!).$(PODS_ROOT)/...only — no absolute checkout path in the generated xcconfig.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit