Fix useFetch paginated URL factory errors#75
Open
mralonsocorona wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a
useFetchpaginated URL factory edge case where the first page URL could be evaluated during render and throw synchronously beforeusePromisehad a chance to expose the error througherrororonError.Problem
For static URLs, invalid URL errors happen inside the async fetch path and are handled by
usePromise.For paginated URL factories,
useFetchevaluated the first page URL during render to track the first page cache key. If the URL factory threw, the error escaped before the normal async error handling path.Changes
useFetchcalls withtypeof url === "function".usePromisecan expose them through its normal error handling.Validation
npm run lintnpm run buildFixes #64