Skip to content

chore(deps): bump SkiaSharp/HarfBuzz + test tooling; hold AngleSharp - #339

Merged
raroche merged 1 commit into
mainfrom
deps/group-bump-and-golden-repin
Jul 10, 2026
Merged

chore(deps): bump SkiaSharp/HarfBuzz + test tooling; hold AngleSharp#339
raroche merged 1 commit into
mainfrom
deps/group-bump-and-golden-repin

Conversation

@raroche

@raroche raroche commented Jul 10, 2026

Copy link
Copy Markdown
Owner

Applies the safe half of the Dependabot group update (#324/#334) + consolidates the HarfBuzz individual PRs, and holds the part that regresses rendering.

Bumped

Held (the rest of #324/#334)

AngleSharp 1.5.2 / AngleSharp.Css beta.216 — regresses background-image rendering. Verified by isolation: with only these two reverted (Skia/HarfBuzz kept new), the suite goes green; with them bumped, background-image: url(...) stops painting entirely (29 background-paint tests → zero image output, + one cascade edge case). Kept at 1.1.2 / beta.144 with an explanatory comment in Directory.Packages.props.

Validation

Full solution green locally — 8606 unit tests + all golden/snapshot/visual-corpus projects, 0 failures. No golden re-pin needed (the safe bumps don't change output).

Supersedes held Dependabot PRs #324, #334, #328, #329.

🤖 Generated with Claude Code

Applies the safe half of the Dependabot group update and consolidates the
individual HarfBuzz PRs into one consistent bump:

- HarfBuzzSharp (core + Linux/macOS/Win32 native) 8.3.1.1 -> 8.3.1.5, all in
  lockstep (supersedes #328/#329, which bumped only the macOS/Win32 natives to
  14.2.1 and left core at 8.x — a managed/native mismatch).
- SkiaSharp (core + natives) 3.119.2 -> 3.119.4.
- Test tooling: xunit 2.9.3, Microsoft.NET.Test.Sdk 17.14.1, coverlet 6.0.4,
  SharpFuzz 2.3.0, Microsoft.Playwright 1.61.0.
- Microsoft.CodeAnalysis.CSharp 4.11.0 -> 4.14.0 (stays below the SDK compiler,
  so no Roslyn build-floor regression — unlike the reverted #331's 5.6.0).

HELD: AngleSharp 1.5.2 / AngleSharp.Css beta.216 (the rest of the group, #324/
#334). Verified by isolation that this pair REGRESSES background-image rendering
— `background-image: url(...)` stops painting entirely (29 background-paint tests
drop to zero image output, plus one cascade edge case). Kept at 1.1.2/beta.144.

Full solution green (8606 unit + all golden/snapshot/visual-corpus projects);
no golden re-pin needed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 10, 2026 02:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates centrally-managed package versions to take the “safe” dependency bumps (SkiaSharp/HarfBuzz + test tooling + Roslyn) while explicitly holding AngleSharp/AngleSharp.Css at known-good versions due to a reported background-image rendering regression.

Changes:

  • Bump HarfBuzzSharp (+ native assets) and SkiaSharp (+ native assets) to newer patch versions.
  • Update test tooling packages (xunit, .NET Test SDK, coverlet, SharpFuzz, Playwright).
  • Update Microsoft.CodeAnalysis.CSharp to 4.14.0 with expanded rationale, while keeping AngleSharp/AngleSharp.Css pinned with a “do not bump” note.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Directory.Packages.props
Comment on lines +40 to +41
<PackageVersion Include="SharpFuzz" Version="2.3.0" />
<PackageVersion Include="Microsoft.Playwright" Version="1.61.0" />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants