Skip to content

fix: forward match_dates to metrics() in html/full/basic #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kelvingao wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: forward match_dates to metrics() in html/full/basic #536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions quantstats/reports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,7 @@ def html(
prepare_returns=False,
benchmark_title=benchmark_title,
strategy_title=strategy_title,
match_dates=match_dates,
)[2:]

# Format metrics table for HTML display
Expand Down Expand Up @@ -903,6 +904,7 @@ def full(
prepare_returns=False,
benchmark_title=benchmark_title,
strategy_title=strategy_title,
match_dates=match_dates,
)
)

Expand Down Expand Up @@ -949,6 +951,7 @@ def full(
prepare_returns=False,
benchmark_title=benchmark_title,
strategy_title=strategy_title,
match_dates=match_dates,
)
print("\n\n")
print("[Worst 5 Drawdowns]\n")
Expand Down Expand Up @@ -1088,6 +1091,7 @@ def basic(
prepare_returns=False,
benchmark_title=benchmark_title,
strategy_title=strategy_title,
match_dates=match_dates,
)
iDisplay(iHTML("<h4>Strategy Visualization</h4>"))
else:
Expand All @@ -1111,6 +1115,7 @@ def basic(
prepare_returns=False,
benchmark_title=benchmark_title,
strategy_title=strategy_title,
match_dates=match_dates,
)

print("\n\n")
Expand Down