Support opening-message attachments for CLI and WebUI#4
Closed
ralphite wants to merge 1 commit into
Closed
Conversation
ralphite
deleted the
codex/conduct-comprehensive-quality-assurance-testing
branch
July 24, 2026 06:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
--imageand--fileflags toagentrunner newand reuseloadImageAttachments/loadFileAttachmentsto pass attachments in the daemon command (internal/cli/conversation.go).RunRequestwithInitialInputand implementopeningInputto convert run commands carrying attachments into aprotocol.UserInputthat the hosted run receives (internal/daemon/daemon.go).Loop.InitialInputand, when present, journal the openingInitialInputviajournalInput(attachments are CAS-stored and the InputReceived fact carries refs); fall back to legacy text-only ingestion when absent (internal/agent/loop.go).images/filesin/api/sessions(new session) and translate them intoar new --image/--fileargs after validating the upload paths (webui/api.go).AR.newSessionpayload to includeimages/files, allow attachment-only submission in the Home composer (provide a helpful default prompt), and send attachments with the new session request (webui/frontend/src/api.ts,webui/frontend/src/components/Composer.tsx).TestNewOpeningAttachmentsAreJournaledto assertagentrunner new --image ...journals an InputReceived with image refs and typed content (internal/cli/conversation_test.go).Testing
go test ./internal/cli -run TestNewOpeningAttachmentsAreJournaled -count=1— test passed.go test ./internal/daemonand the relevantinternal/agentchecks for multimodal behavior — these targeted runs completed successfully in this environment.npm run buildinwebui/frontend— build succeeded and produceddist/for embedding../scripts/check.shcould not complete here because the environment Go toolchain isgo1.25.0while the repo requires Go1.25.12+/1.26.5+or newer, so the full check-gate was not green in this environment.Codex Task