Conversation
- utils: rename stale useThrottle import in apps/web to match renamed hook - ui/Button: synthesise aria-label for icon-only buttons (WCAG 4.1.2) - ui/DataTable: fix stale closure in sort handler (functional state update) - utils/date: use non-padded day so 1 March formats as 1/03/2024 (en-AU) - bunfig/tsconfig: restore happy-dom DOM env for ui tests; add bun-types for tsc All tests pass (13/13) and tsc --noEmit is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and type errors in the monorepo.
bun testnow reports 13 pass / 0 fail andnpx tsc --noEmitexits clean. No test files were modified and no dependencies were added.Bugs fixed
apps/web/src/lib/api.ts@e2e/utilsno longer exportsuseThrottle; updated the import to the current hook name sotscresolves the module.packages/ui/src/components/Button/Button.tsxaria-labelso they have an accessible name (WCAG 4.1.2). Text buttons are left unchanged.packages/ui/src/components/DataTable/DataTable.tsxpackages/utils/src/format/date.ts01/03/2024); now formats without a leading zero (1/03/2024) while keeping theen-AUlocale.bunfig.tomlhappy-domDOM environment forpackages/uitests, which were throwingReferenceError: document is not defined.tsconfig.jsonbun-typessotscrecognisesbun:testimports. Verified React/JSX/hook typechecking remains fully live.Verification
bun test-> 13 pass / 0 failnpx tsc --noEmit-> exit 0git diff --name-onlyconfirms no test files changed and no dependency changes.Assumptions / notes
bunfig.tomlandtsconfig.jsonare treated as configuration, not test files.aria-labeluses a"Button"fallback where no label is supplied; a stricter discriminated-union prop type would require editing a test file, so it was left out.<th>inDataTableis mouse-only (WCAG 2.1.1) and untouched here. Recommend a follow-up.Generated with autonomous agent