[Relocator] Show referenced symbol in overflow diagnostics - #1617
Open
quic-areg wants to merge 1 commit into
Open
[Relocator] Show referenced symbol in overflow diagnostics#1617quic-areg wants to merge 1 commit into
quic-areg wants to merge 1 commit into
Conversation
quic-areg
requested review from
Parth (parth-07) and
Shankar Easwaran (quic-seaswara)
as code owners
July 30, 2026 01:16
Shankar Easwaran (quic-seaswara)
requested changes
Jul 30, 2026
Parth (parth-07)
approved these changes
Aug 3, 2026
Parth (parth-07)
left a comment
Parth (parth-07)
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, but it seems that some tests need to be updated to use the new diagnostic format.
quic-areg
force-pushed
the
overflow-diag
branch
from
August 4, 2026 22:32
6d2687a to
95eee31
Compare
quic-areg
requested review from
Parth (parth-07) and
Shankar Easwaran (quic-seaswara)
August 5, 2026 15:16
Shankar Easwaran (quic-seaswara)
requested changes
Aug 5, 2026
Shankar Easwaran (quic-seaswara)
left a comment
Shankar Easwaran (quic-seaswara)
left a comment
Contributor
There was a problem hiding this comment.
All of your changes look great, but I would like this change to be split into smaller pieces.
For this update, we only need the bare minimum required to show the input file. Any additional diagnostic enhancements can be submitted separately as follow-on improvements.
Also, please keep in mind that this change will need to be cherry-picked to 23.x as well. For 23.x we just need the bare minimum.
| /// True for the synthetic script input created for a --defsym assignment. | ||
| void setIsDefSym() { IsDefSym = true; } | ||
|
|
||
| bool isDefSym() const { return IsDefSym; } |
Contributor
There was a problem hiding this comment.
This should be in a seperate commit.
| std::string ScriptCommand::getContextWithLineNumber() const { | ||
| return getContext() + (hasLineNumberInContext() | ||
| ? ":" + std::to_string(getLineNumberInContext()) | ||
| : ""); |
Contributor
There was a problem hiding this comment.
We should seperate this to a seperate commit.
quic-areg
force-pushed
the
overflow-diag
branch
2 times, most recently
from
August 7, 2026 18:18
288160f to
5839073
Compare
Extend the relocation overflow error diagnostic to show the path and name for the referenced symbol. Fixes qualcomm#755 Signed-off-by: quic-areg <aregmi@qti.qualcomm.com>
quic-areg
force-pushed
the
overflow-diag
branch
from
August 11, 2026 21:09
5839073 to
617318e
Compare
Shankar Easwaran (quic-seaswara)
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the relocation overflow error diagnostic to show the path and
name for the referenced symbol:
references ('sym') for an object-defined symbol
references <script>:('sym') for a linker script assignment or PROVIDE
references '--defsym sym' for a --defsym symbol
references linker internal symbol 'sym' for an internal symbol
Undefined and section symbols keep the old references 'sym' form.
Fixes #755