tests: cover the named GPT attribute flags - #157
Open
Royyan Zahir (royzah) wants to merge 1 commit into
Open
Conversation
Nothing exercised the flags added in qualcomm-linux#137. Add the to_bool forms, the A/B slot flags, priority and tries-remaining masking, and named-flag precedence over --attributes. Signed-off-by: Royyan Zahir <royzah@gmail.com>
Royyan Zahir (royzah)
requested review from
Dmitry Baryshkov (lumag),
Nicolas Dechesne (ndechesne) and
Viswanath Kraleti (vkraleti)
as code owners
August 10, 2026 12:29
Contributor
Author
|
Igor Opaniuk (@igoropaniuk) Can you check this too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The named flags from #137 have no unit coverage. Add tests for the to_bool forms, the A/B slot flags, priority and tries-remaining masking, and named-flag precedence over
--attributes.Tests only, no behaviour change. 43 -> 74 unit tests, all green.