PENDING: arm64: dts: qcom: glymur: Add Glymur RCM board support

[Pankaj (pankaj-qcom)]

The Glymur RCM board inherits most of the hardware from Glymur CRD, include glymur-crd.dts and override only the model and compatible strings.

RCM does not use the same DP3/eDP PHY and the eDP 3.3V panel supply regulator

[qlijarvis]

🔨 Build Failure Analysis — PR #1605

PR: #1605
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30524844495

#	Error	File:Line	PR-introduced?	Root Cause
1	Reference to non-existent node "mdss_dp0_out"	glymur.dtsi:2873	Yes	Deleting &mdss node breaks phandle reference from DP0 PHY endpoint
2	Reference to non-existent node "mdss_dp1_out"	glymur.dtsi:2945	Yes	Deleting &mdss node breaks phandle reference from DP1 PHY endpoint
3	Reference to non-existent node "mdss_dp2_out"	glymur.dtsi:5162	Yes	Deleting &mdss node breaks phandle reference from DP2 PHY endpoint
4	Reference to non-existent node "mdss_dp3_phy" (2 instances)	glymur.dtsi:6109	Yes	Deleting &mdss_dp3_phy node breaks phandle reference from display clock controller

Verdict

All 4 unique errors (5 error instances) are introduced by this PR due to incomplete node deletion that leaves dangling phandle references.

📎 Detailed analysis: Full report

[qlijarvis]

🔨 Build Failure Analysis — PR #1605

PR: #1605
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30524844495

#	Error	File:Line	PR-introduced?	Root Cause
1	ERROR (phandle_references): Reference to non-existent node or label "mdss_dp0_out"	glymur.dtsi:2873	Yes	PR deletes &mdss node which contains the mdss_dp0_out label, but glymur.dtsi PHY port still references it
2	ERROR (phandle_references): Reference to non-existent node or label "mdss_dp1_out"	glymur.dtsi:2945	Yes	PR deletes &mdss node which contains the mdss_dp1_out label, but glymur.dtsi PHY port still references it
3	ERROR (phandle_references): Reference to non-existent node or label "mdss_dp2_out"	glymur.dtsi:5162	Yes	PR deletes &mdss node which contains the mdss_dp2_out label, but glymur.dtsi PHY port still references it
4	ERROR (phandle_references): Reference to non-existent node or label "mdss_dp3_phy" (2 occurrences)	glymur.dtsi:6109	Yes	PR explicitly deletes &mdss_dp3_phy node, but glymur.dtsi clock-controller still references it

Verdict

All 5 errors (4 unique phandle reference failures) are introduced by this PR. The PR deletes device tree nodes that are still referenced by other parts of the device tree hierarchy.

📎 Detailed analysis: Full report

[qlijarvis]

PR #1605 — validate-patch

PR: #1605

Verdict	Issues	Detailed Report
⚠️	2	Full report

Final Summary

1. Lore link present: No — DNM: prefix; no lore link expected for work-in-progress code
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — DNM prefix indicates not intended for upstream submission at this time
4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1605 - DNM: arm64: dts: qcom: glymur: Add Glymur RCM board support
Upstream commit: N/A
Verdict: ⚠️ PARTIAL

Commit Message

Check	Status	Note
Subject matches upstream	N/A	DNM: prefix indicates work-in-progress, not intended for upstream
Body preserves rationale	✅	Clear description of board relationship and hardware differences
Fixes tag present/correct	N/A	New board support, no bug fix
Authorship preserved	✅	Original author in From: field
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/Makefile	✅	Adds glymur-rcm.dtb to build
arch/arm64/boot/dts/qcom/glymur-rcm.dts	✅	New board DTS inheriting from glymur-crd.dts

Issues

• DNM prefix without upstream plan: The DNM: (Do Not Merge) prefix indicates this is work-in-progress or test code. The commit message does not explain why this is marked DNM or what conditions would allow it to be merged.
• Missing integration presence: According to integration_presence_report.md, this commit is not present in qcom-next or any kernel topic branch. For a DNM commit, this may be expected, but it should be clarified whether this is intended for eventual integration.

Verdict

This is a DNM (Do Not Merge) commit adding Glymur RCM board support. The technical content is sound - it correctly inherits from glymur-crd.dts and removes incompatible hardware nodes. However, the DNM prefix requires clarification: is this temporary test code, or does it need additional work before being ready for integration? The commit message should explain the DNM rationale and merge criteria.

Final Summary

1. Lore link present: No — DNM: prefix; no lore link expected for work-in-progress code
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — DNM prefix indicates not intended for upstream submission at this time
4. PR present in qcom-next/topics: No — 1/1 commit missing from both qcom-next and topics (expected for DNM work-in-progress)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 36229361f23e694eb897225a6a859064e11471c5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] DNM: arm64: dts: qcom: glymur: Add Glymur RCM board support	missing - no subject, patch-id, or full tree-content match found	missing - no subject, patch-id, or full tree-content match found	missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

[qlijarvis]

PR #1605 — checker-log-analyzer

PR: #1605
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30524842158

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	1 warning: undocumented DT compatible string
dt-binding-check	⏭️	No binding changes
dtb-check	✅	Test passed
sparse-check	⏭️	No C/H file changes
check-uapi-headers	⏭️	No UAPI changes
check-patch-compliance	❌	Missing required prefix
tag-check	❌	Subject prefix required (base branch is not qcom-next/qcom-next-staging)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1605 - DNM: arm64: dts: qcom: glymur: Add Glymur RCM board support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/30524842158
Base branch: tech/all/dt/glymur

Checker	Result	Summary
checkpatch	❌	1 warning: undocumented DT compatible string
dt-binding-check	⏭️	No binding changes
dtb-check	✅	Test passed
sparse-check	⏭️	No C/H file changes
check-uapi-headers	⏭️	No UAPI changes
check-patch-compliance	❌	Missing required prefix
tag-check	❌	Subject prefix required (base branch is not qcom-next/qcom-next-staging)

---

❌ checkpatch

Root cause: The compatible string "qcom,glymur-rcm" is not documented in Documentation/devicetree/bindings/vendor-prefixes.yaml or a board-specific binding.

Failure details:

WARNING: DT compatible string "qcom,glymur-rcm" appears un-documented -- check ./Documentation/devicetree/bindings/
#48: FILE: arch/arm64/boot/dts/qcom/glymur-rcm.dts:12:
+	compatible = "qcom,glymur-rcm", "qcom,glymur";

9869589291efbf3c5fd69f7c56bb95f259f4c6ac total: 0 errors, 1 warnings, 0 checks, 25 lines checked

Fix: Add a device tree binding for the Glymur RCM board. Create Documentation/devicetree/bindings/arm/qcom.yaml entry (or update existing) to document qcom,glymur-rcm:

- items:
    - enum:
        - qcom,glymur-rcm
    - const: qcom,glymur

Alternatively, if this is a vendor-internal board variant not intended for upstream, the warning can be noted but may be acceptable for internal trees.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git d687d3581f64935e6993a720ee35c1240f3353ad..ad940b85f713ec506335f21695e399ea5a751bb8

---

❌ check-patch-compliance

Root cause: The commit subject line starts with DNM: which is not a recognized upstream-linkable prefix.

Failure details:

Checking commit: DNM: arm64: dts: qcom: glymur: Add Glymur RCM board support
Commit summary does not start with a required prefix

Fix: The check-patch-compliance checker enforces upstream-linkable prefixes only. Valid prefixes are:

• FROMLIST: — patch posted to mailing list (lore.kernel.org)
• FROMGIT: — patch taken from a maintainer git tree
• UPSTREAM: — patch merged into Linus's mainline tree
• BACKPORT: — upstream patch backported with modifications

DNM: (Do Not Merge) is a common internal marker but is not accepted by this checker. Since this appears to be a vendor-internal board addition, the appropriate prefix would be QCLINUX: (vendor-only change with no upstream equivalent).

However, note that QCLINUX: is also not in the checker's allowed list — this is a known limitation. The checker will always fail for vendor-only commits. If this board is intended for upstream submission, use FROMLIST: and add a Link: trailer pointing to the lore.kernel.org posting.

Reproduce locally:

# This checker requires the full automerge + PR merge context
bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . \
  --base 897f09a4172e753933bd013312e766eff9340509 --head 6cc2a62c0a6c510eeecce1d502b6fcea578988c8

---

❌ tag-check

Root cause: The PR targets branch tech/all/dt/glymur, which is not qcom-next or qcom-next-staging. All commits merged into branches other than those two must start with a valid subject-line prefix tag.

Failure details:

Commit 9869589291ef ("DNM: arm64: dts: qcom: glymur: Add Glymur RCM board support")
Subject line: "DNM: arm64: dts: qcom: glymur: Add Glymur RCM board support"
Missing required prefix.

The subject starts with DNM: which is not a valid prefix tag. Valid prefix tags are:

• FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix: Amend the commit to add the appropriate prefix:

git rebase -i d687d3581f64935e6993a720ee35c1240f3353ad
# mark commit 9869589291ef as 'edit'
git commit --amend -m "QCLINUX: DNM: arm64: dts: qcom: glymur: Add Glymur RCM board support"
# or if posted upstream:
git commit --amend -m "FROMLIST: arm64: dts: qcom: glymur: Add Glymur RCM board support"
git rebase --continue

Choose the correct prefix based on the patch origin:

• If this is a vendor-only board not intended for upstream → QCLINUX:
• If posted to lore but not yet merged → FROMLIST: (and add Link: trailer)
• If in a maintainer tree → FROMGIT:
• If merged into Linus's tree → UPSTREAM:

Note: The DNM: marker can be kept after the prefix if needed for internal tracking: QCLINUX: DNM: arm64: dts: ...

---

Verdict

3 blockers must be fixed before merge:

1. checkpatch — Add DT binding documentation for qcom,glymur-rcm or accept the warning if this is vendor-internal only.
2. check-patch-compliance — Change subject prefix from DNM: to a valid upstream-linkable prefix (FROMLIST:, UPSTREAM:, etc.) or QCLINUX: for vendor-only (note: QCLINUX: will still fail the checker due to known limitation).
3. tag-check — Add a valid subject-line prefix tag (QCLINUX:, FROMLIST:, etc.) since the target branch is not qcom-next or qcom-next-staging.

Recommended action: If this is a vendor-internal board not intended for upstream submission, change the subject to:

QCLINUX: arm64: dts: qcom: glymur: Add Glymur RCM board support

And accept that check-patch-compliance will continue to fail (known checker limitation for vendor-only commits). The checkpatch warning can also be accepted for vendor-internal boards.

If this board is intended for upstream, post it to the devicetree mailing list, add the binding documentation, and use:

FROMLIST: arm64: dts: qcom: glymur: Add Glymur RCM board support

<commit body>

Link: https://lore.kernel.org/...
Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>

[qlijarvis]

🔨 Build Failure Analysis — PR #1605

PR: #1605
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30993563463

#	Error	File:Line	PR-introduced?	Root Cause
1	Reference to non-existent node "mdss_dp0_out"	glymur.dtsi:2873	Yes	/delete-node/ &mdss; removes mdss subsystem containing dp0 output port label
2	Reference to non-existent node "mdss_dp1_out"	glymur.dtsi:2945	Yes	/delete-node/ &mdss; removes mdss subsystem containing dp1 output port label
3	Reference to non-existent node "mdss_dp2_out"	glymur.dtsi:5162	Yes	/delete-node/ &mdss; removes mdss subsystem containing dp2 output port label
4	Reference to non-existent node "mdss_dp3_phy" (1st)	glymur.dtsi:6117	Yes	/delete-node/ &mdss_dp3_phy; removes PHY node referenced by dispcc clock controller
5	Reference to non-existent node "mdss_dp3_phy" (2nd)	glymur.dtsi:6117	Yes	/delete-node/ &mdss_dp3_phy; removes PHY node referenced by dispcc clock controller (duplicate reference)

Verdict

All 5 errors are introduced by this PR. The /delete-node/ statements remove nodes that are still referenced by other parts of the device tree.

📎 Detailed analysis: Full report

[qlijarvis]

🔨 Build Failure Analysis — PR #1605

PR: #1605
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30993563463

#	Error	File:Line	PR-introduced?	Root Cause
1	Reference to non-existent node "mdss_dp0_out"	glymur.dtsi:2873	Yes	PR deletes &mdss node but leaves dangling phandle references in PHY port endpoints
2	Reference to non-existent node "mdss_dp1_out"	glymur.dtsi:2945	Yes	PR deletes &mdss node but leaves dangling phandle references in PHY port endpoints
3	Reference to non-existent node "mdss_dp2_out"	glymur.dtsi:5162	Yes	PR deletes &mdss node but leaves dangling phandle references in PHY port endpoints
4	Reference to non-existent node "mdss_dp3_phy"	glymur.dtsi:6117	Yes	PR deletes &mdss_dp3_phy node but clock controller still references it
5	Reference to non-existent node "mdss_dp3_phy" (duplicate)	glymur.dtsi:6117	Yes	PR deletes &mdss_dp3_phy node but clock controller still references it

Verdict

All 5 errors are introduced by this PR. The base glymur-crd.dtb builds successfully; only the new glymur-rcm.dtb fails.

📎 Detailed analysis: Full report

[qlijarvis]

PR #1605 — validate-patch

PR: #1605

Verdict	Issues	Detailed Report
❌	3	Full report

Final Summary

1. Lore link present: No — DNM: prefix; no lore.kernel.org link found in commit message
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — DNM: prefix indicates not intended for upstream (or not yet posted)
4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1605 - DNM: arm64: dts: qcom: glymur: Add Glymur RCM board support
Upstream commit: N/A
Verdict: ❌ FAIL

Commit Message

Check	Status	Note
Subject matches upstream	N/A	No upstream source - DNM prefix indicates vendor-only
Body preserves rationale	✅	Describes board relationship and hardware differences
Fixes tag present/correct	N/A	Not a fix commit
Authorship preserved	N/A	No upstream to compare against
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/Makefile	⚠️	Adds glymur-rcm.dtb to build - no upstream reference
arch/arm64/boot/dts/qcom/glymur-rcm.dts	⚠️	New board DTS - includes glymur-crd.dts, deletes nodes - no upstream reference

Issues

• Missing lore link: No lore.kernel.org link found in commit message. The DNM: prefix indicates "Do Not Merge" - typically used for work-in-progress, testing, or vendor-specific changes not intended for upstream submission.
• Not present in integration branches: According to integration_presence_report.md, this commit is missing from both qcom-next and kernel topics branches (0/1 commits present).
• Commit prefix ambiguity: The DNM: prefix is not in the standard set documented in the skill (UPSTREAM:, FROMLIST:, FROMGIT:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:). While DNM: clearly signals "Do Not Merge", it should be clarified whether this is intended as a PENDING: (work-in-progress) or QCLINUX: (vendor-only) commit.

Verdict

Do not merge. This commit lacks a lore.kernel.org link and is not present in qcom-next or topics branches. The DNM: prefix explicitly marks it as "Do Not Merge". If this is intended for integration:

1. Remove the DNM: prefix and replace with an appropriate prefix (QCLINUX: for vendor-only, PENDING: for work-in-progress, or FROMLIST: with a lore link if posted upstream)
2. Ensure the commit is present in the appropriate integration branch before merging to topics

Final Summary

1. Lore link present: No — DNM: prefix; no lore.kernel.org link found in commit message
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — DNM: prefix indicates not intended for upstream (or not yet posted)
4. PR present in qcom-next/topics: Fail — 1/1 commit(s) are missing from both qcom-next and topics (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 8d5dbc1b17adf8fe86a41adcda686785e73f5414
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] DNM: arm64: dts: qcom: glymur: Add Glymur RCM board support	missing - no subject, patch-id, or full tree-content match found	missing - no subject, patch-id, or full tree-content match found	missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

[qlijarvis]

PR #1605 — checker-log-analyzer

PR: #1605
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/30993564806

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	1 warning: undocumented DT compatible string
dt-binding-check	⏭️	No binding changes
dtb-check	✅	Passed
sparse-check	⏭️	No C/H file changes
check-uapi-headers	⏭️	No C/H file changes
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Subject missing required prefix (applies to topic branches)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1605 - DNM: arm64: dts: qcom: glymur: Add Glymur RCM board support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/30993564806

Checker	Result	Summary
checkpatch	❌	1 warning: undocumented DT compatible string
dt-binding-check	⏭️	No binding changes
dtb-check	✅	Passed
sparse-check	⏭️	No C/H file changes
check-uapi-headers	⏭️	No C/H file changes
check-patch-compliance	❌	Missing required subject prefix
tag-check	❌	Subject missing required prefix (applies to topic branches)

---

❌ checkpatch

Root cause: The compatible string qcom,glymur-rcm is not documented in devicetree bindings.

Failure details:

WARNING: DT compatible string "qcom,glymur-rcm" appears un-documented -- check ./Documentation/devicetree/bindings/
#48: FILE: arch/arm64/boot/dts/qcom/glymur-rcm.dts:12:
+	compatible = "qcom,glymur-rcm", "qcom,glymur";

ea32ca4eb55beadd1b15ff03cc137cea99be9dae total: 0 errors, 1 warnings, 0 checks, 25 lines checked

Fix: Add the qcom,glymur-rcm compatible string to the appropriate devicetree binding YAML file. Since this board is a variant of Glymur CRD, you should:

1. Locate the Glymur board binding file (likely Documentation/devicetree/bindings/arm/qcom.yaml)
2. Add qcom,glymur-rcm to the compatible enum list
3. Include this binding update as a separate patch before the DTS patch

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 7f4025eedfe6ed2931b096663dd7f501a82aa6d9..85594d74910cb42fe120466f842a1d5578189247

---

❌ check-patch-compliance

Root cause: The commit subject starts with DNM: which is not a recognized upstream-linkable prefix.

Failure details:

Checking commit: DNM: arm64: dts: qcom: glymur: Add Glymur RCM board support
Commit summary does not start with a required prefix

Fix: The check-patch-compliance checker requires one of these prefixes: FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:.

Since this appears to be a vendor-specific board addition (DNM = Do Not Merge), you have two options:

1. If this is vendor-only work: Change prefix to QCLINUX: (note: this will still fail check-patch-compliance but is the correct vendor prefix)
2. If this will be posted upstream: Change prefix to FROMLIST: and add a Link: tag pointing to the lore.kernel.org URL once posted

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: glymur: Add Glymur RCM board support"
# (keep rest of commit message)
git rebase --continue

---

❌ tag-check

Root cause: The commit subject does not start with a required prefix tag. This check applies because the PR targets a topic branch (topic/tech/all/dt/glymur), not qcom-next or qcom-next-staging.

Failure details:

Commit ea32ca4eb55b ("DNM: arm64: dts: qcom: glymur: Add Glymur RCM board support")
Subject line: "DNM: arm64: dts: qcom: glymur: Add Glymur RCM board support"

The subject starts with DNM: which is not a valid prefix. All commits merged into topic branches must start with one of:

• FROMLIST: (posted to mailing list)
• FROMGIT: (from maintainer tree)
• UPSTREAM: (merged into mainline)
• BACKPORT: (backported with modifications)
• QCLINUX: (vendor-only)
• PENDING: (work-in-progress)
• WORKAROUND: (temporary fix)

Fix: Same as check-patch-compliance above. Change the subject prefix:

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: glymur: Add Glymur RCM board support"
git rebase --continue

Choose QCLINUX: if this is vendor-only hardware support with no upstream equivalent.

---

Verdict

2 blockers must be fixed before merge:

1. Add DT binding documentation for qcom,glymur-rcm compatible string (checkpatch warning)
2. Fix subject prefix from DNM: to a valid prefix like QCLINUX: (check-patch-compliance + tag-check failures)

Note: Using QCLINUX: prefix will still cause check-patch-compliance to fail (known checker limitation for vendor-only commits), but it is the correct prefix for vendor-specific board support. The tag-check will pass with QCLINUX:.