Fix qlrd release pr - #28
Merged
Merged
Conversation
This commit updates application to it's internet-less installer, i.e, for now every installation will download upstream from latest release, i.e., v26.08.0 to be released. Another third step added was the reproductibility hashes on github actions's logs, so an interested user could compare his/her own krux firmware build with those downloaded, hashed, verified and embeeded on CI. It's expected that the first build of this commit will fail and the previous commit (4216e0aa) isn't the final one and this should be tagged after firwmare release, so it will download the correct firmware (and thus show to users correct reproductibility hashes). It's expected that the subsequent builds (starting from a3fac76) build with success accompained with same firmware hashes produced by `uv run python reproductibility.py` on `selfcustody/krux` repo. For purposes of verification, every rebase should be accompained with his commit hashes for `git` inspection. - 4216e0aa - a3fac76
joaozinhom
marked this pull request as draft
August 4, 2026 19:04
qlrd
marked this pull request as ready for review
August 4, 2026 19:17
qlrd
added a commit
that referenced
this pull request
Aug 4, 2026
This commit updates application to it's internet-less installer, i.e, for now every installation will download upstream from latest release, i.e., v26.08.0 to be released. Another third step added was the reproductibility hashes on github actions's logs, so an interested user could compare his/her own krux firmware build with those downloaded, hashed, verified and embeeded on CI. It's expected that the first build of this commit will fail and the previous commit (4216e0aa) isn't the final one and this should be tagged after firwmare release, so it will download the correct firmware (and thus show to users correct reproductibility hashes). It's expected that the subsequent builds (starting from a3fac76) build with success accompained with same firmware hashes produced by `uv run python reproductibility.py` on `selfcustody/krux` repo. For purposes of verification, every rebase should be accompained with his commit hashes for `git` inspection. - 4216e0aa - a3fac76 - e6c00af (co-authored by @joazinhom on #27) - abf7a51 (co-authored by @joazinhom on #28) Co-authored-by: joaozinhom <joaomcr@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
important to mentions the claude helps me with some tricks and with the all the test coverage