Give the progress bar a proper width also when the output is piped - #310
Open
hannahbast wants to merge 1 commit into
Open
Give the progress bar a proper width also when the output is piped#310hannahbast wants to merge 1 commit into
hannahbast wants to merge 1 commit into
Conversation
When the output of `qlever update-wikidata` is piped (for example, through `tee` to keep a log file), `tqdm` cannot detect the terminal width and falls back to a bar of only 10 characters. Use the width from the `COLUMNS` environment variable (or 80) in that case; on a terminal, the width remains dynamic as before.
There was a problem hiding this comment.
Pull request overview
This PR improves the user experience of qlever update-wikidata by ensuring the tqdm progress bar has a sensible width even when output is piped (e.g., through tee), where terminal-width auto-detection can fail.
Changes:
- Determine a
tqdmncolsvalue dynamically when running on a TTY, and fall back toCOLUMNS/default width when not on a TTY. - Pass the computed
ncolsinto thetqdm_logging_redirectprogress bar used for batch processing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the output of
qlever update-wikidatais piped (for example, throughtee -a update-log.txtto keep a log file, which became attractive now that #307 keeps the colors),tqdmcannot detect the terminal width and falls back to a bar of only 10 characters. With this change, the width is taken from theCOLUMNSenvironment variable (or 80 if it is not set) in that case; on a terminal, the width remains dynamic as before.NOTE:
bashdoes not exportCOLUMNSby default, so for a bar that really spans the whole terminal in the piped case, addexport COLUMNSto the shell profile; without it, the bar is 80 characters wide.