Repository navigation
IMP: expose colorPalette parameter for all visualizers - #112
Conversation
|
Hey @VinzentRisch, I'm just going to expose this for all viz's (just to improve developer customization for all of the plots). I'll do this and add a few small tests asserting color choice and then this should be ready for your review (if you don't mind) 🙂 |
|
Hey @VinzentRisch this is ready for a review 🙂 Apologies in advance; the test changes needed for this were fairly substantial. Some refactoring was required to make the selenium tests slightly less of a monstrosity; I opened up an issue for myself to refactor these further to pull out what checks aren't strictly browser-required, but that was out of scope for this PR. |
colorPalette parametercolorPalette parameter for all visualizers
|
Hey @lizgehret |
All good, thanks @VinzentRisch! I'll see if @misialq has time before then, otherwise when you get back is great 🙂 |
misialq
left a comment
There was a problem hiding this comment.
Hey @lizgehret, this all looks pretty good to me - I just have some wording update suggestions below, let me know what you think! I did try it with some plots and it all seemed to work as expected 🚀
|
Thanks for the feedback @misialq! This should be ready for a final review 🙂 |
Description
Closes #103. Exposes the colorPalette parameter for all visualizations; discrete & continuous palettes implemented for scatterplot(s).
AI Disclosure
AI Usage Details
Claude Opus 5.5 was used to refactor the existing selenium tests to account for the additional parameters and desired test cases, reviewed by me. All new (non-selenium) tests & implementation/refactoring done by me.