Repository navigation
Conversation
Member
Author
|
Note that a Paired- branch name has been utilized to account for rachis-org/rachis#950 - since this is blocking a new round of prepares, this needs to be tested in tandem to actually run the tests (otherwise boots chokes on the unknown param name) |
lizgehret
changed the title
lizgehret
commented
Jul 15, 2026
| self.assertTrue(observed_table.shape, (2, 90)) | ||
| # modified 15 July 2026 from (2, 90) to accommodate changes in: | ||
| # https://github.com/bokulich-lab/q2-kmerizer/pull/12 | ||
| self.assertEqual(observed_table.shape, (2, 94)) |
Member
Author
There was a problem hiding this comment.
This was also previously just doing a truth assertion, which wouldn't ever fail - so this has been fixed to assert the expected shape
1 of 2 tasks
Member
Author
|
no longer needed, @ebolyen to add a PR in kmerizer so the tests behave as previously expected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes failures in the modified test that were caused by changes in bokulich-lab/q2-kmerizer#12. Now that terminal kmers are included, this changed the number of observed features as well as the jaccard distance (listing these two specifically because these are what is examined in the test). Below are my local reproductions of the updated values (first jaccard then observed features); I used the latest passed qiime2 environment (from 29 June) that includes dev installs of q2-boots, rachis and q2-kmerizer.
AI Disclosure