Skip to content

dev is red #731

Closed
Closed

Description

@github-actions

CI on dev is red, so main stays at the last green dev SHA (0bad606). The fast lane keeps merging into dev; the next green dev run promotes main and closes this issue.

Commits in the range, newest first:

Activity

  1. added
    dev-redCI on dev is red; main holds the last green dev SHA
    on Oct 14, 2026
  2. prakashUXtech commented on Oct 14, 2026

    @prakashUXtech
    Contributor

    The macOS job fails to build AppSnapshotTests at one line:

    Tests/AppSnapshotTests/CanvasViewportSnapshots.swift:20:107: error: 'name' is inaccessible due to 'fileprivate' protection level

    That's scheme.name. The ColorScheme.name helper in AppSnapshotTests.swift:126 is file-private, and #711 (feat(suiteui): CanvasViewport zooms itself…) added the use. The fix is on the SuiteUI line: make that helper internal, or spell the name out in the new file. No test ran, so this run says nothing about the other PRs in the range. PhotoApp, including the new TileCanvas.swift from #729, compiled cleanly.

  3. prakashUXtech commented on Oct 14, 2026

    @prakashUXtech
    Contributor

    Reopened. #732 closed this by keyword when it merged, but dev still fails 4 macOS UI journeys in run 38535591962 (Design audit, Library loupe contrast, Photo straighten). A fixer is working on them and will report here.

  4. github-actions commented on Oct 14, 2026

    @github-actions
    ContributorAuthor

    dev is green again at ee57a15 (https://github.com/qbtrix/creative-apps/actions/runs/38548253551), and main now points there.

  5. prakashUXtech commented on Oct 14, 2026

    @prakashUXtech
    Contributor

    Dev is green: https://github.com/qbtrix/creative-apps/actions/runs/38548253551 (ee57a15). Linux, macOS, Promote and Audit lower all passed.

    • fix(ui): clear the dev-red journey failures in Design, Library and Photo #734 fixed three things:
      • Design. Added identifiers to Add Page, Delete Page, the fill/text color row, the empty state's New File and SuiteUI's document title menu; the identifier count went from 30 to 20. Hidden layer rows now use SuiteColor.textSecondary. The multi-select rows are no longer .disabled, which had dimmed their labels to 2:1.
      • Photo. Select > All was disabled while a sheet was up, and the disabled item still took Command-A. It now hands Command-A to the text field being edited, and it never selects the canvas while a sheet is up.
      • Library. The loupe became a labelled container. This alone didn't fix it.
    • fix(library): the loupe readout keeps its own frame, not the whole loupe's #735 fixed the real Library cause. The loupe's photo was hidden from accessibility, so the position readout was the focusable loupe's only element and took its 648x560 frame. The audit then read the photo as text ink. The photo is now a labelled image element, and the readout sits outside the focusable part.

    No baselines, tests or checks were changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dev-redCI on dev is red; main holds the last green dev SHA

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions